Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust angular to not require node typings. #15107

Merged
merged 1 commit into from
May 25, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented May 25, 2021

Add "types": [], to tsconfig.app.json like angular-cli fresh generated application.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima changed the title Change webpack config to don't use process.env (requires node typings) Adjust angular to not require node typings. May 25, 2021
@DanielFran DanielFran merged commit b45bd42 into jhipster:main May 25, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
@mshima mshima deleted the skip_ci-angular_webpack branch June 19, 2021 12:13
@mshima mshima mentioned this pull request Jun 20, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants