Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootswatch update theme #15141

Merged
merged 6 commits into from
May 27, 2021
Merged

Conversation

pascalgrimaud
Copy link
Member

It will allow to use the new themes :-D


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud
Copy link
Member Author

Thanks for adding the area+theme, @atomfrede !

@mshima
Copy link
Member

mshima commented May 27, 2021

I am wondering if bootswatch 5 is compatible with bootstrap 4.

@pascalgrimaud
Copy link
Member Author

Indeed @mshima
As I saw we already have it: https://github.com/jhipster/generator-jhipster/blob/main/generators/client/templates/vue/package.json#L9

And manually tests work fine

@DanielFran DanielFran closed this May 27, 2021
@DanielFran DanielFran reopened this May 27, 2021
@DanielFran
Copy link
Member

DanielFran commented May 27, 2021

Closing/reopening since CI failed unexpectedly...

@DanielFran DanielFran merged commit 787686a into jhipster:main May 27, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
@istibekesi
Copy link

@pascalgrimaud @DanielFran
It seems "bootswatch": "5.1.3" is present in react/vue templates, but missing in angular.
So in case of angular, it fails to build with Quartz theme, since that new theme is not included in bootswatch 4.6.1 at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants