Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vue] Fix OneToOne fields binding in update entity select #15147

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

swarajsaaj
Copy link
Contributor

Fix #15130


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member

mshima commented May 28, 2021

At angular, ${relationshipFieldNamePlural}Collection Is filtered for one-to-one available values while ${otherEntityName}Collection isn't.
Don’t know about vue.

@swarajsaaj
Copy link
Contributor Author

@mshima In Angular, somehow there are multiple ${relationshipFieldNamePlural}Collection arrays created (startLocationsCollection and destionationLocationsCollection) even for the same relationship target entity (HikingLocation).

<%_ for (const relationship of relationshipsWithCustomUniqueOptions) { _%>
<%= relationship.relationshipFieldNamePlural %>Collection: I<%= relationship.otherEntityAngularName %>[] = [];
<%_ } _%>

But in Vue, only a single array for options is created in component i.e. relationshipFieldNamePlural (hikingLocations)

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@atomfrede atomfrede merged commit 5c60d9c into jhipster:main Jun 15, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone Jun 17, 2021
@swarajsaaj
Copy link
Contributor Author

@pascalgrimaud
Copy link
Member

@swarajsaaj : approved and thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue does not display relations in edit view out of box
4 participants