Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cypress e2e ci packaging error on copy #15150

Merged
merged 1 commit into from
May 31, 2021
Merged

fix cypress e2e ci packaging error on copy #15150

merged 1 commit into from
May 31, 2021

Conversation

nomuna
Copy link
Contributor

@nomuna nomuna commented May 28, 2021

Fix #15146


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@nomuna nomuna changed the title remove hard coded string from regex in index.js fix cypress e2e ci packaging error on copy May 28, 2021
@mshima
Copy link
Member

mshima commented May 29, 2021

@atomfrede is there an easy way to generate the package with e2e.jar name instead of version.jar like maven?
This copy workaround can conflict if there is more than 1 package.

@atomfrede
Copy link
Member

Let me check. Don't know for sure right now.

@atomfrede
Copy link
Member

The property in gradle is bootJar.archiveFileName, but I didn't find a way to provide it via cli parameter/flag.

@mshima
Copy link
Member

mshima commented May 31, 2021

Thanks, I couldn't find either back when I did maven change.

Maybe we could delegate to gradle to copy current version.
./gradlew copy_e2e_jar to copy archiveFileName to e2e.jar.

Seems a bit more complicated.
Merging this one for now.

@mshima mshima merged commit 94f67e0 into jhipster:main May 31, 2021
@atomfrede
Copy link
Member

✔️ Have already an idea how to do it via cli parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress e2e CI packaging error on copy
5 participants