Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: wrong dbEngine for PostgreSQL #15154

Merged
merged 1 commit into from
May 30, 2021
Merged

Conversation

gmarziou
Copy link
Contributor

@gmarziou gmarziou commented May 29, 2021

The right value of dbEngine is "postgres" not "postgresql" as documented in AWS.

I haven't tested it with AWS, I only did a code review and saw which commit introduced the regression: 972b1e8

Fix: #15151


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

The right value of `dbEngine` is "postgres" not  "postgresql" as [documented in AWS](https://docs.aws.amazon.com/cli/latest/reference/rds/create-db-instance.html#options).

Fix: jhipster#15151
@pascalgrimaud pascalgrimaud merged commit 8b541cb into jhipster:main May 30, 2021
@gmarziou gmarziou deleted the aws_engine branch May 30, 2021 09:02
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS subgenerator throws Invalid DB engine for PostgreSQL
3 participants