Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjusts to workflows. #15244

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Minor adjusts to workflows. #15244

merged 5 commits into from
Jun 9, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Jun 7, 2021

Related to #15205 and #15129.

Description in each commit.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshima Just to be sure, if we want to use in generator a bom released version we just needs to update jhipster-bom-branch value to release?

Then this will apply to generator and daily builds if we use same action file?

How about in bom project? Should we define bom branch as local in each workflow to override the property?

@mshima
Copy link
Member Author

mshima commented Jun 7, 2021

@mshima Just to be sure, if we want to use in generator a bom released version we just needs to update jhipster-bom-branch value to release?

Yes, change here

Then this will apply to generator and daily builds if we use same action file?

Yes, if the workflow doesn't override the default value.

How about in bom project? Should we define bom branch as local in each workflow to override the property?

There is no local option for jhipster-bom-branch. It will try to load the branch local.
When executed by jhipster-bom repository it executes

if [[ "$JHI_REPO" == *"/jhipster-bom" ]]; then
echo "*** jhipster: use local version at JHI_LIB_HOME=$JHI_LIB_HOME"
cd "$JHI_LIB_HOME"
git --no-pager log -n 10 --graph --pretty='%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit
test-integration/scripts/10-replace-version-jhipster.sh
./mvnw -ntp clean install -Dgpg.skip=true --batch-mode
ls -al ~/.m2/repository/tech/jhipster/jhipster-framework/
ls -al ~/.m2/repository/tech/jhipster/jhipster-dependencies/
ls -al ~/.m2/repository/tech/jhipster/jhipster-parent/

@mshima mshima merged commit e5d3b0d into jhipster:main Jun 9, 2021
@mshima mshima deleted the skip_ci-ci_adjusts branch June 9, 2021 01:30
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants