-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor adjusts to workflows. #15244
Minor adjusts to workflows. #15244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mshima Just to be sure, if we want to use in generator a bom released version we just needs to update jhipster-bom-branch value to release?
Then this will apply to generator and daily builds if we use same action file?
How about in bom project? Should we define bom branch as local in each workflow to override the property?
Yes, change here
Yes, if the workflow doesn't override the default value.
There is no local option for jhipster-bom-branch. It will try to load the branch local. generator-jhipster/test-integration/scripts/10-install-jhipster.sh Lines 11 to 22 in 2156b13
|
Related to #15205 and #15129.
Description in each commit.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.