Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protractor tests #15245

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Fix protractor tests #15245

merged 3 commits into from
Jun 8, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Jun 7, 2021

Apply same fix of 11dfed8#diff-c14159cc6cbb565f01325eed42e2932a5c0fe58c47a93ed84bea30fa41dcfa6c to vue and angular. (https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/915434261, https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/915492593)

Fix react pattern validation related to #15191 (https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/916298820)


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielFran DanielFran merged commit 0abbc72 into jhipster:main Jun 8, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone Jun 11, 2021
@mshima mshima deleted the skip_ci-protractor branch June 19, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants