-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mssql and r2dbc integration #15264
fix mssql and r2dbc integration #15264
Conversation
2c79435
to
29f1b4a
Compare
29f1b4a
to
e54bfbe
Compare
...rators/server/templates/src/main/resources/config/liquibase/changelog/initial_schema.xml.ejs
Outdated
Show resolved
Hide resolved
…e/changelog/initial_schema.xml.ejs Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
@atomfrede @jhipster/developers We are using an explicit liquibase extension sabomichal/liquibase-mssql that allow defining the property identityInsertEnabled="true" to allows explicit values to be inserted into the identity column of a table, so the same as defining "SET IDENTITY_INSERT jhi_user ON/OFF". In the meantime, the support of official MSSQL is up-to-date, so we probably should migrate back to the official liquibase extension. So there are 2 possibilities: |
...rators/server/templates/src/main/resources/config/liquibase/changelog/initial_schema.xml.ejs
Show resolved
Hide resolved
I would say let's use the official extension. |
But very strange it doesn't work with |
Liquibase version we are using is version 4 and actually the extension was compatible with version 3, not sure there is any issue with the version 4. Anyway Liquibase should handle now reactive database also, so I agree the better is to switch with liquibase official extension. |
@DanielFran Done. Works fine (tested with reactive only though, but don't see why it should not work with classical jdbc). |
@atomfrede Can you please review tests? |
On it. Seems easy to fix. |
generators/server/templates/src/main/java/package/repository/rowmapper/UserRowMapper.java.ejs
Outdated
Show resolved
Hide resolved
…owmapper/UserRowMapper.java.ejs Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
@atomfrede LGTM Maybe we need to delete https://www.jhipster.tech/tips/004_tip_using_ms_sql_server.html I will take care of the bom |
Bounty claimed https://opencollective.com/generator-jhipster/expenses/42719. Regarding the tip, there is already a disclaimer that the tip is not required anymore. But maybe it is time to delete it now. |
@atomfrede : approved |
This PR fixes all issues mentioned in #15032
asEntity('User')
everywherecloses #15032
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.