Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement common script to configure azure pipelines #15284

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Jun 10, 2021


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as ready for review June 11, 2021 20:04
@DanielFran
Copy link
Member

DanielFran commented Jun 14, 2021

@mshima LGTM

Note: To be consistent, it would be better to use scripts 20 to 24 in the other workflows too? (example: https://github.com/jhipster/generator-jhipster/blob/main/.github/workflows/angular.yml#L276-L293)
I see inconsistences for example here

@mshima
Copy link
Member Author

mshima commented Jun 14, 2021

I see inconsistences for example here

I like to have npm run * instead of the scripts for the main repository for visibility.
But would be ok to use the scripts too.

@mshima mshima merged commit b5440fc into jhipster:main Jun 14, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone Jun 17, 2021
@mshima mshima deleted the skip_ci-azure branch June 19, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants