Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts to Microfrontend. #15312

Merged
merged 8 commits into from
Jun 14, 2021
Merged

Adjusts to Microfrontend. #15312

merged 8 commits into from
Jun 14, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Jun 13, 2021

  • Add generator tests.
  • Change microservice/microfrontend web server proxy to use gateway port.
  • Throw error when generating Microfrontend with others client frameworks.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@MathieuAA MathieuAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found this typo

…vices_index.html.ejs

Co-authored-by: Mathieu ABOU-AICHI <MathieuAA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants