Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use constants in utils folder #15724

Merged
merged 2 commits into from
Jul 25, 2021

Conversation

renanfranca
Copy link
Contributor

@renanfranca renanfranca commented Jul 24, 2021

contributes to #14235


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2021

CLA assistant check
All committers have signed the CLA.

@renanfranca renanfranca marked this pull request as ready for review July 24, 2021 00:44
utils/liquibase.js Outdated Show resolved Hide resolved
@mshima mshima merged commit 3d7f1aa into jhipster:main Jul 25, 2021
@mshima
Copy link
Member

mshima commented Jul 25, 2021

Thanks and congrats for the first contribution.

@renanfranca
Copy link
Contributor Author

@mshima thank you very much! I'm really happy be part of JHipster community as contribute now!

I did a really small pull request to learn the contribution cycle, thank you to point exactly what i need to fix and for fix it for me this time. I've already learn a lot while studying the JHipster codebase and keep learning!😃

@renanfranca renanfranca deleted the use-constants-in-utils-folder branch July 26, 2021 13:13
@pascalgrimaud pascalgrimaud added this to the 7.2.0 milestone Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants