Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Downgrade webpack-dev-server (error) #16028

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Aug 22, 2021

Revert 3e25a05#diff-45ad775caf02ce958066eda2b4a911763e810750a9dfaf3ca618a09306bbed87

npm start not working with the new version
image

Without --inline, there is an other error
image

Need a fix to upgrade
Doc is here https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert requested a review from deepu105 August 23, 2021 08:19
@deepu105
Copy link
Member

are you on an LTS of Node?

Copy link
Member

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont remember having issues wth this, unless this was updated recenly. ANyway ok to downgrade

@qmonmert
Copy link
Contributor Author

are you on an LTS of Node?

node 14.16.0

@qmonmert
Copy link
Contributor Author

I dont remember having issues wth this, unless this was updated recenly. ANyway ok to downgrade

did you test since 4 days ?

@mraible
Copy link
Contributor

mraible commented Aug 23, 2021

I can confirm this happens with the latest main branch.

My Node version:

➜  react-app git:(main) node --version
v14.17.0

If I downgrade like this PR has, it works.

@qmonmert qmonmert merged commit aa9f347 into jhipster:main Aug 23, 2021
@pascalgrimaud pascalgrimaud added this to the 7.2.0 milestone Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants