Avoid using mavenLocal() in build.gradle?

[nickshoe]

Overview of the feature request

While reading the Gradle documentation to configure Gradle to use my private Nexus repository, I ran into this advice in the official documentation regarding maven repositories:

As a general advice, you should avoid adding mavenLocal() as a repository...

Existing code:

generator-jhipster/generators/server/templates/build.gradle.ejs

Lines 283 to 285 in 1b76ae1

	repositories {
	mavenLocal()
	mavenCentral()

Motivation for or Use Case

As stated in the doc's chapter "Obtaining module metadata":

• Each repository is inspected in order.
  • Depending on the type of repository, Gradle looks for metadata files describing the module (.module, .pom or ivy.xml file) or directly for artifact files.
  • Modules that have a module metadata file (.module, .pom or ivy.xml file) are preferred over modules that have an artifact file only.
  • Once a repository returns a metadata result, following repositories are ignored.

(penultimate point)

• All of the artifacts for the module are then requested from the same repository that was chosen in the process above.

(callout)

The penultimate point above is what can make the integration with Maven Local problematic. As it is a cache for Maven, it will sometimes miss some artifacts of a given module. If Gradle is sourcing such a module from Maven Local, it will consider the missing artifacts to be missing altogether.

Related issues or PR

• Checking this box is mandatory (this is just to show you read everything)

[atomfrede]

Yes, I in fact thought we removed it already.

[nickshoe]

Ok, I'll make the PR.

[nickshoe]

Sorry for the mess, I've used hub cli and it created the PR against the old "master" branch. Now it's against "main".

[nickshoe]

I've tried to regenerate snapshots, but for some reason it changes a lot of files due to different convention for strings and escaping chars (maybe it's related to WSL2 usage). I've destroyed the last commit and force pushed the only commit containing the actual code.

[mshima]

JHipster uses mavenLocal() for jhipster-bom at CI.
Would require us to start using snapshots (https://github.com/orgs/jhipster/packages?repo_name=jhipster-bom) instead.

[nickshoe]

Hey @mshima I'm new to CI concepts and practices.. ':D
Can you point me to an explanation/tutorial of what jhipster-bom and snapshots are?
Let me know if I can do something to this PR.
Thanks

[atomfrede]

Ah you are right @mshima . Didn't remember why we kept it.

[mshima]

@atomfrede what do you think about this now?

[atomfrede]

Sorry missed the review request.