Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Replace react-infinite-scroller by react-infinite-scroll-comp… #17071

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Nov 20, 2021

Fix #17064


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added theme: dependencies Pull requests that update a dependency file theme: react labels Nov 20, 2021
@mshima
Copy link
Member

mshima commented Nov 20, 2021

From what we could see from the api, it looks correct.
I will generate a project with it soon. Unless @mraible beats me =).
@qmonmert can you try removing .npmrc file please?

@qmonmert
Copy link
Contributor Author

@mshima done

@qmonmert qmonmert changed the title [React] Replace react-infinite-scroller by react-infinite-scroll-comp… WIP: [React] Replace react-infinite-scroller by react-infinite-scroll-comp… Nov 21, 2021
@qmonmert qmonmert changed the title WIP: [React] Replace react-infinite-scroller by react-infinite-scroll-comp… [React] Replace react-infinite-scroller by react-infinite-scroll-comp… Nov 21, 2021
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the following jdl:

application {
  config {
    clientFramework react
  }
  entities *
}

entity Foo {
  bar String
}

paginate Foo with infinite-scroll

@DanielFran DanielFran merged commit ea9ac6a into jhipster:main Nov 22, 2021
@pascalgrimaud pascalgrimaud added this to the 7.4.1 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file theme: front theme: react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace react-infinite-scroller.
4 participants