Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sort converter to elasticsearch search repository #17193

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

indiepopart
Copy link
Contributor

Fix #17018

Add SortToFieldSortBuilderConverter for SearchRepositoryInternal to append ".keyword" suffix to sort property for elasticsearch paginated queries.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2021

CLA assistant check
All committers have signed the CLA.

@Tcharl
Copy link
Contributor

Tcharl commented Dec 2, 2021

Marvelous!
Is it possible to add a small unit test? At least one to check the presence of the builder source.

@indiepopart
Copy link
Contributor Author

Marvelous! Is it possible to add a small unit test? At least one to check the presence of the builder source.

Working on it, thank you.

@Tcharl Tcharl merged commit f111ffb into jhipster:main Dec 6, 2021
@pascalgrimaud pascalgrimaud added this to the 7.5.0 milestone Dec 10, 2021
@indiepopart indiepopart deleted the fix-elasticsearch-sort branch March 16, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UncategorizedElasticsearchException Please use a keyword field instead. Alternatively, set fielddata=true
4 participants