Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Fix: this.userManagementService is not a function #17569

Merged
merged 2 commits into from Jan 18, 2022

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jan 15, 2022

Fix #17565


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member

mshima commented Jan 15, 2022

Is there a problem with cypress tests or with samples?
It was supposed to test this use case.

@qmonmert
Copy link
Contributor Author

@mshima bug with simple app #17565

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only page visit is implemented at cypress tests.
The PR should fix the error, but I think a basic regression test would be nice.

@qmonmert
Copy link
Contributor Author

@mshima are you ok with that?

@mshima mshima merged commit f5d6289 into jhipster:main Jan 18, 2022
@pascalgrimaud pascalgrimaud added this to the 7.6.0 milestone Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue client: userManagementService is not provided
3 participants