Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump npm to 8.5.x and fixes to workspaces support. #17910

Merged
merged 10 commits into from
Mar 15, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Feb 18, 2022

Move swagger-ui-dist dependency to common. It's used inside an iframe, it's not framework dependent.

Move swagger-ui-dist dependency to dev. It's bundled, so it's not a prod dependency.

Move swagger-ui-dist asset from angular.json to webpack config. Due to workspaces deduplication, it cannot be static.

Change relative imports to node/require imports to fix errors at workspaces deduplication.

Remove elasticsearch from webflux-gradle-session-mariadb and drop webflux-mongodb (jwt is tested by others samples). Related to #18053


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran changed the title Bump npm to 8.5.0 and add workarounds. Bump npm to 8.5.1 and add workarounds. Feb 18, 2022
@mshima mshima marked this pull request as draft February 18, 2022 12:01
@mshima
Copy link
Member Author

mshima commented Feb 18, 2022

Another npm bug npm/cli#4439.

@DanielFran DanielFran changed the title Bump npm to 8.5.1 and add workarounds. Bump npm to 8.5.2 and add workarounds. Mar 1, 2022
@DanielFran DanielFran changed the title Bump npm to 8.5.2 and add workarounds. Bump npm to 8.5.x and add workarounds. Mar 4, 2022
@mshima mshima force-pushed the skip_ci-npm_8_5_0 branch 2 times, most recently from a24b066 to cb53145 Compare March 7, 2022 03:17
@mshima mshima force-pushed the skip_ci-npm_8_5_0 branch 5 times, most recently from 02d12c5 to 2c72df3 Compare March 7, 2022 12:34
@mshima mshima changed the title Bump npm to 8.5.x and add workarounds. Bump npm to 8.5.x and fixes to workspaces support. Mar 7, 2022
@mshima mshima marked this pull request as ready for review March 7, 2022 14:52
@mshima mshima marked this pull request as draft March 7, 2022 16:27
@mshima mshima marked this pull request as ready for review March 7, 2022 17:22
@mshima mshima closed this Mar 8, 2022
@mshima mshima reopened this Mar 8, 2022
@mshima mshima marked this pull request as draft March 10, 2022 12:49
@mshima
Copy link
Member Author

mshima commented Mar 10, 2022

Trying another approach due to npm/cli#4437.

@mshima
Copy link
Member Author

mshima commented Mar 12, 2022

#18081 didn't work.
We should use this approach for now.

@mshima mshima marked this pull request as ready for review March 12, 2022 17:34
@mshima mshima merged commit 9472395 into jhipster:main Mar 15, 2022
@mshima mshima deleted the skip_ci-npm_8_5_0 branch March 15, 2022 16:36
@pascalgrimaud pascalgrimaud added this to the 7.8.0 milestone Mar 27, 2022
ko5tik pushed a commit to ko5tik/generator-jhipster that referenced this pull request May 21, 2022

Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants