Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spring-boot version to 2.6.5 #17967

Merged
merged 12 commits into from
Mar 24, 2022

Conversation

DanielFran
Copy link
Member


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran
Copy link
Member Author

DanielFran commented Feb 24, 2022

Seems that gradle plugin issue is fixed.

@DanielFran DanielFran closed this Feb 24, 2022
@DanielFran DanielFran reopened this Feb 24, 2022
@DanielFran DanielFran closed this Feb 25, 2022
@DanielFran DanielFran reopened this Feb 25, 2022
@DanielFran DanielFran force-pushed the spring-boot_2.6.4 branch 2 times, most recently from 3b820a6 to 895a595 Compare March 10, 2022 18:14
@mshima mshima marked this pull request as ready for review March 11, 2022 01:42
@mshima mshima marked this pull request as draft March 11, 2022 01:42
@mraible
Copy link
Contributor

mraible commented Mar 11, 2022

@DanielFran Do you know why this upgrade fails?

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Mar 11, 2022
@DanielFran
Copy link
Member Author

DanielFran commented Mar 11, 2022

@mraible I identified several issues so far:

  • MongoDB is broken, the workaround done by @mshima in previous version do not work anymore
  • Couchbase also did not work, maybe @tchlyah can help on this
  • Issues with UserService with webflux, after the upgrade it did not return users

@mshima
Copy link
Member

mshima commented Mar 11, 2022

Rebased the bom branch for couchbase.

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@mraible mraible changed the title Update spring-boot version to 2.6.4 Update spring-boot version to 2.6.5 Mar 24, 2022
@DanielFran DanielFran closed this Mar 24, 2022
@DanielFran DanielFran reopened this Mar 24, 2022
@DanielFran DanielFran closed this Mar 24, 2022
@DanielFran DanielFran reopened this Mar 24, 2022
@DanielFran
Copy link
Member Author

@mraible @mshima Everything is green!?!

Will deploy BOM and update repos...

@DanielFran DanielFran marked this pull request as ready for review March 24, 2022 18:50
@DanielFran DanielFran merged commit 435dcdd into jhipster:main Mar 24, 2022
@DanielFran
Copy link
Member Author

@mshima I propose to divide the bug bounty 50/50
Is it OK for you?

@pascalgrimaud pascalgrimaud added this to the 7.8.0 milestone Mar 27, 2022
@mshima
Copy link
Member

mshima commented Mar 29, 2022

@DanielFran sorry the delay. You take 350, I take 150.
You did more here.

@pascalgrimaud
Copy link
Member

No @mshima
Take each one 500 plz, you did so much for the project, it's deserved

@DanielFran
Copy link
Member Author

@pascalgrimaud
Copy link
Member

@DanielFran : approved

@mshima
Copy link
Member

mshima commented Apr 6, 2022

@pascalgrimaud
Copy link
Member

@mshima : approved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: CI builds theme: java theme: jhipster-internals $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants