Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Apache Maven Wrapper 3.1.0 and Maven 3.8.4 #18005

Merged
merged 8 commits into from
Mar 2, 2022

Conversation

DanielFran
Copy link
Member


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran
Copy link
Member Author

@mshima Can you help me with snapshots, on Windows I am not able to update them automatically because it add lot of slash like here:

context: 10-couchbase\\\\src\\\\main\\\\docker

@mshima
Copy link
Member

mshima commented Mar 1, 2022

Need to execute normalize-path at relativePath:

const relativePath = pathjs.relative(this.destinationRoot(), `${path}/src/main/docker`);

And here:
const cqlFilesRelativePath = pathjs.relative(this.destinationRoot(), `${path}/src/main/resources/config/cql`);

Probably it’s not only the snapshot that is affected.

@DanielFran DanielFran merged commit b21ade1 into jhipster:main Mar 2, 2022
@DanielFran
Copy link
Member Author

Thanks @mshima

@pascalgrimaud pascalgrimaud added this to the 7.8.0 milestone Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants