Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the reversed version problem for maven-enforcer-plugin rule config #18040

Merged
merged 2 commits into from
Mar 7, 2022
Merged

fix the reversed version problem for maven-enforcer-plugin rule config #18040

merged 2 commits into from
Mar 7, 2022

Conversation

Bernankez
Copy link
Contributor

fix the reversed version problem for maven-enforcer-plugin rule config
when generating jhipster with a low version of java

Fix #18038


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

fix the reversed version problem for maven-enforcer-plugin rule config
when generating jhipster with a low version of java

Fix #18038
@CLAassistant
Copy link

CLAassistant commented Mar 3, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverse changes the original array, so duplicate before reversing.

generators/generator-base-private.js Outdated Show resolved Hide resolved
@mshima mshima merged commit bf947d0 into jhipster:main Mar 7, 2022
@pascalgrimaud pascalgrimaud added this to the 7.8.0 milestone Mar 27, 2022
ko5tik pushed a commit to ko5tik/generator-jhipster that referenced this pull request May 21, 2022
jhipster#18040)

* fix the reversed version problem for maven-enforcer-plugin rule config

fix the reversed version problem for maven-enforcer-plugin rule config
when generating jhipster with a low version of java

Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator generated an invalid version config for maven-enforcer-plugin in pom.xml
4 participants