Drop allow-circular-references. #18095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
force-pushed
the
skip_ci-circular
branch
3 times, most recently
from
9f2ca48
to
44aa82a
Compare
mshima
force-pushed
the
skip_ci-circular
branch
from
59ed258
to
267e220
Compare
|
So starting JHipster 7.8.0 we are now favoring duplicate of code than "reusing relationship otherEntity mappers" For example if I have more than 10 mappers that has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapstruct mapper were reusing relationship otherEntity mappers causing a circular dependency.
With this PR, relationship mappers are generated at the entity mapper itself, removing external mappers reuse.
Fixes #17774.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.