-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions to v3 and rename workflow #18101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should keep the template as github-actions or put at the correct path.
Otherwise main.yml is too generic.
WDYT?
@mshima I agree that |
Sure. That’s what I mean. Keep the template as github-actions.yml and rename. |
The renaming to
main.yml
is based on my recent experience.build.yml
is another good alternative, IMO.Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.