Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions to v3 and rename workflow #18101

Merged
merged 7 commits into from
Mar 12, 2022
Merged

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Mar 12, 2022

The renaming to main.yml is based on my recent experience. build.yml is another good alternative, IMO.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should keep the template as github-actions or put at the correct path.
Otherwise main.yml is too generic.

WDYT?

@mraible
Copy link
Contributor Author

mraible commented Mar 12, 2022

@mshima I agree that main.yml might be too generic for the generator-jhipster project. However, I think it's appropriate to name it main.yml (or build.yml) in the generated project.

@mshima
Copy link
Member

mshima commented Mar 12, 2022

@mshima I agree that main.yml might be too generic for the generator-jhipster project. However, I think it's appropriate to name it main.yml (or build.yml) in the generated project.

Sure. That’s what I mean. Keep the template as github-actions.yml and rename.

@mraible mraible merged commit 2aa6f6d into main Mar 12, 2022
@mraible mraible deleted the ci-cd-improvements branch March 12, 2022 23:59
@pascalgrimaud pascalgrimaud added this to the 7.8.0 milestone Mar 27, 2022
ko5tik pushed a commit to ko5tik/generator-jhipster that referenced this pull request May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants