Move workflow samples to external files #18135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
force-pushed
the
skip_ci-workflow_samples
branch
2 times, most recently
from
a742f2f
to
ffad841
Compare
mshima
commented
Mar 16, 2022
mshima
force-pushed
the
skip_ci-workflow_samples
branch
from
e789d47
to
217206a
Compare
mshima
force-pushed
the
skip_ci-workflow_samples
branch
from
217206a
to
5a91f2c
Compare
mshima
force-pushed
the
skip_ci-workflow_samples
branch
from
5a91f2c
to
9df92df
Compare
|
@mshima Seems good. Is it missing webflux? |
|
I think we should move webflux samples to angular/react/vue workflows |
DanielFran
approved these changes
Mar 17, 2022
mshima
added a commit
to Tcharl/generator-jhipster
that referenced
this pull request
Mar 17, 2022
mshima
changed the title
ko5tik
pushed a commit
to ko5tik/generator-jhipster
that referenced
this pull request
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow jhipster-bom project to auto pick samples changes.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.