Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 17785 - fix search with sort for reactive and elasticsearch options #18155

Merged
merged 6 commits into from
Mar 22, 2022

Conversation

maznag
Copy link
Contributor

@maznag maznag commented Mar 19, 2022

Proposed PR to fix #17785.

Please make sure the below checklist is followed for Pull Requests.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2022

CLA assistant check
All committers have signed the CLA.

@DanielFran
Copy link
Member

@maznag something wrong. Can you rebase?

@maznag
Copy link
Contributor Author

maznag commented Mar 21, 2022

@maznag something wrong. Can you rebase?

@DanielFran Ooops ! sorry, I completely create new branch from my last commit before previous rebase and do new rebase. I don't know what happened on my last rebase :-). I think everything is ok now

@mshima mshima closed this Mar 22, 2022
@mshima mshima reopened this Mar 22, 2022
@DanielFran
Copy link
Member

@maznag By mistake, I send you the index.js path to server generator instead of entity-server generator.
I fixed the removal of SortToSortBuilderListConverter class directly in your branch

@DanielFran
Copy link
Member

DanielFran commented Mar 22, 2022

Thanks @maznag for the contribution

@DanielFran DanielFran merged commit f827e7e into jhipster:main Mar 22, 2022
@maznag
Copy link
Contributor Author

maznag commented Mar 22, 2022

Thank you to you too @DanielFran :-)

@maznag maznag deleted the fix/issue-17785 branch March 22, 2022 12:27
@maznag
Copy link
Contributor Author

maznag commented Mar 22, 2022

@pascalgrimaud there is a bounty on this ticket. This is the link to OpenCollective expense https://opencollective.com/generator-jhipster/expenses/68435. Thanks in advance !

@pascalgrimaud
Copy link
Member

@maznag : approved, thanks for your work ;)

@pascalgrimaud pascalgrimaud added this to the 7.8.0 milestone Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch exception No mapping found for [date.keyword] in order to sort on
5 participants