Split server cleanup in multiple files #18449
Conversation
Tcharl
force-pushed
the
testcontainers_elastic
branch
from
d822f36
to
b327855
Compare
Tcharl
force-pushed
the
testcontainers_elastic
branch
from
b327855
to
276fe00
Compare
|
@Tcharl maybe rename method cleanupOldServerFiles to cleanupOldFiles? |
|
@DanielFran |
| @@ -0,0 +1,37 @@ | |||
| /** | |||
There was a problem hiding this comment.
This belongs to the server generator .
There was a problem hiding this comment.
Not so sure for this one: in the future this method will be in the cleanup file of angular
| @@ -0,0 +1,37 @@ | |||
| /** | |||
There was a problem hiding this comment.
We won’t have h2 generator, we will have sql.
| @@ -0,0 +1,36 @@ | |||
| /** | |||
There was a problem hiding this comment.
We won’t have postgres generator, should be sql.
| @@ -0,0 +1,38 @@ | |||
| /** | |||
There was a problem hiding this comment.
If we split reactive, we may need to split every other tech into imperative/reactive.
We probably should keep it in server.
There was a problem hiding this comment.
I suggest to have a clean-reactive file for everything that is common, but use if(reactive)in the respective cleanup-<tech> for everything related to a particular technology (sql, angular, ...)
|
Clear, I'll take it into account in the next PR (I've a 3 hours flight so will be fixed tonight) |
This pr is meant to help the future split of server variant into multiple generator or sub folders
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.