Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for reactive-ms sample. #18572

Merged
merged 5 commits into from
May 4, 2022
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented May 4, 2022

Fixes #18570


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima changed the title Skip ci reactive ms Tweaks for reactive-ms sample. May 4, 2022
mraible
mraible previously approved these changes May 4, 2022
Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Intel! Not so great on M1.

@mraible
Copy link
Contributor

mraible commented May 4, 2022

Works on M1 too after re-creating images and enabling the new Virtualization framework in Docker.

Screen Shot 2022-05-04 at 09 01 58

mraible
mraible previously approved these changes May 4, 2022
Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit in README

generators/common/templates/README.md.jhi.ejs Outdated Show resolved Hide resolved
Co-authored-by: Matt Raible <matt.raible@okta.com>
@mshima mshima merged commit ac88c7d into jhipster:main May 4, 2022
@mshima mshima deleted the skip_ci-reactive_ms branch May 4, 2022 18:32
@DanielFran DanielFran added this to the 7.9.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run e2e doesn't pass for reactive-ms JDL
3 participants