-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip applications install when generating workspaces. #18869
Conversation
I don't know if I'm testing this branch correctly. Here's what I tried:
I saw the I tried
Then, I tried building Docker images in each app. They all fail. gateway
blog
store
If I run Task :jibDockerBuild FAILED
|
I was able to fix my Docker issues using this answer on Stack Overflow. After fixing Docker, I built each image and ran
This worked! |
73152c1
to
af823ab
Compare
@mraible now it skips install at applications, installs at the root. Tested using:
Then access |
We might want to add some information about Both of these pages show up when I search for "jhipster microservices" and "jhipster microfrontends". |
I love how fast the M1 is for e2e tests!
Here's my
|
Current jdl generation makes npm workspaces unsuitable for auto install.
So disable it by default.
npm 8. changed the workspaces behavior by deduping dependencies to the root.
We generate applications in parallel, so
install
will be executed 3 times in same npm tree causing lots of problems.We need to execute
npm install
only once.Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.