Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sample version for sonar #19481

Merged
merged 4 commits into from
Aug 24, 2022
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Aug 19, 2022

This will allow to track activity based on jhipster version https://sonarcloud.io/project/activity?id=jhipster-sample-application.
Keep sonar implementation at angular workflow only.

Sonar analisys is limited to ngx-default:

if [[ "$JHI_APP" = "ngx-default" && "$GITHUB_REPOSITORY" = "jhipster/generator-jhipster" && "$GITHUB_REF" = "refs/heads/main" ]]; then

Local analysis is broken, sonar is not even started at docker:

elif [[ $JHI_SONAR = 1 ]]; then
echo "*** Sonar analyze locally"
./mvnw -ntp --batch-mode initialize org.jacoco:jacoco-maven-plugin:prepare-agent sonar:sonar \
-Dsonar.host.url=http://localhost:9001 \
-Dsonar.projectKey=JHipsterSonar
sleep 30
docker-compose -f src/main/docker/sonar.yml logs
echo "*** Sonar results:"
curl 'http://localhost:9001/api/measures/component?componentKey=JHipsterSonar&metricKeys=bugs%2Ccoverage%2Cvulnerabilities%2Cduplicated_lines_density%2Ccode_smells'


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima closed this Aug 22, 2022
@mshima mshima reopened this Aug 22, 2022
@mshima mshima closed this Aug 23, 2022
@mshima mshima reopened this Aug 23, 2022
@DanielFran DanielFran merged commit 2ec4dd0 into jhipster:main Aug 24, 2022
@mshima mshima deleted the skip_ci-sonar_version branch August 24, 2022 16:17
@pascalgrimaud pascalgrimaud added this to the 7.9.3 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants