Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up TypeScript #19559

Merged
merged 30 commits into from
Sep 16, 2022
Merged

Set up TypeScript #19559

merged 30 commits into from
Sep 16, 2022

Commits on Sep 15, 2022

  1. Init tsconfig.json

    emilpaw committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    05e7e81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3cd118 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    597161e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dced0f0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    22ba324 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2c44fb8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    47a244c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ba674bb View commit details
    Browse the repository at this point in the history
  9. Ignore some eslint rules

    Ignore some of the @typescript-eslint rules on existing
    JavaScript files.
    emilpaw committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    ad3a502 View commit details
    Browse the repository at this point in the history
  10. Add npm script to copy files

    This script copies all files which are not source files from `generators/` to the build
    output folder `dist`. This is needed since TypeScript only places the generated
    JavaScript files in the `dist` folder but other files from
    `generators/` are also needed in the output.
    emilpaw committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    ba7e067 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4d53612 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7f37c2a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    354ee0f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    19cea6b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    885f3c0 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6f8a148 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    d3adceb View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    51792fa View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    3b8127c View commit details
    Browse the repository at this point in the history
  20. Pin dependencies

    emilpaw committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    cd5df79 View commit details
    Browse the repository at this point in the history
  21. Set build target to ES2022

    emilpaw committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    2901e4a View commit details
    Browse the repository at this point in the history
  22. Ignore more files in copy-files script

    Don't copy files ending with .snap and folders starting with __ (currently __snapshots__ & __workflow)  to build output. These are files needed for tests or CI which have no use in the build output.
    emilpaw committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    022cf4d View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    93e604a View commit details
    Browse the repository at this point in the history
  24. Update cli/environment-builder.js

    mshima authored and emilpaw committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    931bc39 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    018aad2 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    9da2a7c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Don't use build output for /esm/* exports

    When using the build output for these exports the tests which import
    these modules as part of the test case fail.
    
    This has two reasons:
    1. In CI/CD npm run build is not run before the tests so the
       modules fail to be imported. This could be solved by first building
       the package.
    2. In the tests the modules are imported via ES Modules syntax and the
       import function and the result is compared for referential equality.
       When the built file is imported through the import function and
       it's compared to the source file the reference is always
       not the same.
    
    When this part of the code is converted to TypeScript these issues must
    be addressed.
    emilpaw committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    1d8bc65 View commit details
    Browse the repository at this point in the history
  2. Build project in prepare npm script

    This will build the project when it's installed.
    emilpaw committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    590f9fb View commit details
    Browse the repository at this point in the history
  3. Don't build before installing

    This should be done by the prepare npm script now.
    emilpaw committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    76f5592 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0af077b View commit details
    Browse the repository at this point in the history