Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sb3: reinstate infinispan support #20398

Merged
merged 26 commits into from
Mar 22, 2023
Merged

sb3: reinstate infinispan support #20398

merged 26 commits into from
Mar 22, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Nov 19, 2022

Related to #19782
Fixes #21230

  • adds a dedicated gradle script for caches.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima changed the title sb3: Remove inexistent methods sb3: adjust caching Nov 19, 2022
@mshima mshima marked this pull request as draft November 20, 2022 15:45
mraible
mraible previously approved these changes Dec 3, 2022
@mraible
Copy link
Contributor

mraible commented Dec 6, 2022

It looks like snapshots need to be updated in this PR.

@mshima
Copy link
Member Author

mshima commented Dec 6, 2022

Closing/reopen to check new infinispan version.

@mshima mshima closed this Dec 6, 2022
@mshima mshima reopened this Dec 6, 2022
Base automatically changed from spring-boot-3.0-m4 to main December 9, 2022 20:50
@DanielFran DanielFran closed this Dec 10, 2022
@DanielFran DanielFran reopened this Dec 10, 2022
@DanielFran
Copy link
Member

@mshima this needs updates of snapshots and I cannot update them...

Copy link
Member Author

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infinispan is not compatible with sb3 yet.

@mshima
Copy link
Member Author

mshima commented Dec 10, 2022

@DanielFran I will try to update snapshots tonight.

@mraible
Copy link
Contributor

mraible commented Dec 13, 2022

Does this work with Infinispan now? If so, we might want to update the PR's title.

@mshima
Copy link
Member Author

mshima commented Dec 13, 2022

Does this work with Infinispan now? If so, we might want to update the PR's title.

No infinispan support.

@DanielFran
Copy link
Member

@mraible @mshima infinispan spring-boot 3 integration is in progress: infinispan/infinispan#10569

@mshima
Copy link
Member Author

mshima commented Feb 3, 2023

@DanielFran I spent quite some time trying to integrate it.
I've found a lot of problems:

  • It's not officially supported by infinispan, so dependency customizations are applied to the spring-boot bom.
    jhipster-bom was removing the customization, but I've found that spring-boot-dependencies are not used to manage generated project dependencies, so we need to replicate the customization in jhipster-bom instead or add spring-boot-dependencies to the generated application.
  • spring-boot is failing to auto configure infinispan. Adding some manual configuration like forcing infinispan as cache works.
    But:
    • our current customizations does not work when using integrated spring-boot configuration.
    • cache names are not added, we need to change the customization from the java class to application.yml config.
    • annotations with cache names were not working. Caches needed to be added by config application.yml file.
  • it's supposed to be possible to use infinispan using spring-boot jcache support. We could unify configuration using jcache. But spring-boot jcache support just ignores infinispan and take another provider (I don't remember, ehcache maybe).
  • redis support seems to have problems too.

I've got a somewhat functional application with infinispan.
We are not near a v8 release, so I decided to hold and wait for the sb3 cache support to mature.
In any case I think we should cleanup cache support and delegate a lot more to spring-boot.

@DanielFran
Copy link
Member

@mshima
Copy link
Member Author

mshima commented Mar 22, 2023

Added a hardcoded temporary infinispan-bom dependency that should be dropped at #21321.

@mshima mshima marked this pull request as ready for review March 22, 2023 13:56
@mshima
Copy link
Member Author

mshima commented Mar 22, 2023

Please squash when merging.

@mshima mshima changed the title sb3: adjust caching sb3: reinstate infinispan support Mar 22, 2023
@mshima mshima requested a review from DanielFran March 22, 2023 18:56
@DanielFran DanielFran merged commit 349b8cc into main Mar 22, 2023
@DanielFran DanielFran deleted the skip_ci-caching branch March 22, 2023 18:57
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CacheConfiguration.java upgrades for Infinispan library upgrades
3 participants