Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sb3: bump elasticseach container to v8.5.0 #20463

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Nov 28, 2022


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as draft November 28, 2022 13:05
@mshima mshima mentioned this pull request Nov 28, 2022
6 tasks
@mshima mshima changed the title bump elasticseach container to v8.5.0 sb3: bump elasticseach container to v8.5.0 Nov 28, 2022
@mraible
Copy link
Contributor

mraible commented Dec 7, 2022

@mshima This PR seems to have a lot less failures than the current Spring Boot 3 branch. Should we merge it?

@mshima
Copy link
Member Author

mshima commented Dec 7, 2022

@mraible actually, this is due to diff logic applied to the workflows. If there is no change to the generated source, the test is skipped.
It doesn’t fix anything, every elasticsearch project broke, while others didn’t change.

@mraible
Copy link
Contributor

mraible commented Dec 7, 2022

So Elasticsearch v7.17.4 works fine with Spring Boot 3, but v8.5.0 does not? Maybe @xeraa can help.

@mshima
Copy link
Member Author

mshima commented Dec 8, 2022

@mraible no it's just the docker health check that is not working.

test: ['CMD', 'curl', '-f', 'http://localhost:9200/_cluster/health?wait_for_status=green&timeout=10s']
interval: 5s
timeout: 10s

@xeraa
Copy link

xeraa commented Dec 8, 2022

So, since 8.0 security is enabled by default. That means HTTPS only and a random password for the elastic user. Which is generally good, but would make your setup quite a bit more complex. And the health check is the first thing failing — not entirely surprising 😅

You could disable security for this scenario (please, don't do this in general)? I think this should get you sorted:

environment:
  - xpack.security.enabled=false

@DanielFran DanielFran marked this pull request as ready for review December 8, 2022 09:37
@DanielFran DanielFran merged commit 70e0337 into spring-boot-3.0-m4 Dec 8, 2022
@DanielFran DanielFran deleted the skip_ci-bump_elasticseach branch December 8, 2022 09:37
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants