-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sb3: bump elasticseach container to v8.5.0 #20463
Conversation
@mshima This PR seems to have a lot less failures than the current Spring Boot 3 branch. Should we merge it? |
@mraible actually, this is due to diff logic applied to the workflows. If there is no change to the generated source, the test is skipped. |
So Elasticsearch v7.17.4 works fine with Spring Boot 3, but v8.5.0 does not? Maybe @xeraa can help. |
@mraible no it's just the docker health check that is not working. generator-jhipster/generators/docker/templates/src/main/docker/elasticsearch.yml.ejs Lines 35 to 37 in 75898e4
|
So, since 8.0 security is enabled by default. That means HTTPS only and a random password for the You could disable security for this scenario (please, don't do this in general)? I think this should get you sorted:
|
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.