Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup generator-private methods #20944

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Jan 27, 2023

  • move some methods to base/generator.mts (typescript).
  • extract upgradeFilesTask.
  • move gitMove implementation locally at upgradeFilesTask it's used only once for now. (shouldn't be exposed due to api contract).

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit 783eb05 into jhipster:main Jan 27, 2023
@mshima mshima deleted the skip_ci-cleanup-private branch February 4, 2023 14:27
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants