move entity to base-application #20957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
force-pushed
the
skip_ci-generator-base
branch
from
244c602
to
819939d
Compare
mshima
force-pushed
the
skip_ci-generator-base
branch
from
819939d
to
90b2b13
Compare
Tcharl
reviewed
Jan 29, 2023
| /** | ||
| * get sorted list of entitiy names according to changelog date (i.e. the order in which they were added) | ||
| */ | ||
| getExistingEntityNames(): string[] { |
There was a problem hiding this comment.
Should be in a support file isn't it?
There was a problem hiding this comment.
IMO no.
Every core api should be implemented inline in the generator (except some utilities).
And we should avoid utilities to use any complex parameter like the generator and the log.
There was a problem hiding this comment.
Why am I stating that: these APIs will certainly be used by many generators, so we'll avoid passing complex parameters (generator) reusing them by moving this method to a dedicated support package.
I agree generatorshould not be passed as an attribute. LogAdapter looks to be a must (quite systematic) as there's no slf4j-like static injection fwk
mshima
force-pushed
the
skip_ci-generator-base
branch
from
c9d7912
to
775fa04
Compare
DanielFran
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move entity operations from generators/base to generators/base-application.
Generate a temporary
generator-ts.mtsto keep ts implementation whilegeneratoris js.Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.