Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop vue dependencies #21987

Merged
merged 2 commits into from
May 2, 2023
Merged

Drop vue dependencies #21987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d85ce1
drop vue-template-compiler
mshima May 2, 2023
fe8904e
drop fork-ts-checker-webpack-plugin
mshima May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion generators/vue/templates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"css-loader": "6.7.3",
"css-minimizer-webpack-plugin": "5.0.0",
"folder-hash": "4.0.4",
"fork-ts-checker-webpack-plugin": "7.3.0",
"html-webpack-plugin": "5.5.1",
"jest": "29.5.0",
"jest-environment-jsdom": "29.5.0",
Expand Down
2 changes: 0 additions & 2 deletions generators/vue/templates/package.json.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
"copy-webpack-plugin": "<%= nodeDependencies['copy-webpack-plugin'] %>",
"css-loader": "<%= nodeDependencies['css-loader'] %>",
"css-minimizer-webpack-plugin": "<%= nodeDependencies['css-minimizer-webpack-plugin'] %>",
"fork-ts-checker-webpack-plugin": "<%= nodeDependencies['fork-ts-checker-webpack-plugin'] %>",
<%_ if (!skipJhipsterDependencies) { _%>
"generator-jhipster": "<%= jhipsterVersion %>",
<%_ blueprints.forEach(blueprint => { _%>
Expand Down Expand Up @@ -112,7 +111,6 @@
"typescript": "<%= nodeDependencies['typescript'] %>",
"@vue/vue2-jest": "<%= nodeDependencies['@vue/vue2-jest'] %>",
"vue-loader": "<%= nodeDependencies['vue-loader'] %>",
"vue-template-compiler": "<%= nodeDependencies['vue'] %>",
"webpack": "<%= nodeDependencies['webpack'] %>",
"webpack-bundle-analyzer": "<%= nodeDependencies['webpack-bundle-analyzer'] %>",
"webpack-cli": "<%= nodeDependencies['webpack-cli'] %>",
Expand Down
17 changes: 0 additions & 17 deletions generators/vue/templates/webpack/webpack.prod.js.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const CssMinimizerPlugin = require('css-minimizer-webpack-plugin');
const WorkboxPlugin = require('workbox-webpack-plugin');
const TerserPlugin = require('terser-webpack-plugin');
const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');

const { styleLoaders } = require('./vue.utils');
const config = require('./config');
Expand Down Expand Up @@ -98,22 +97,6 @@ const webpackConfig = {
filename: 'content/[name].[contenthash].css',
chunkFilename: 'content/[id].css'
}),
// keep module.id stable when vendor modules does not change
new ForkTsCheckerWebpackPlugin(
{
typescript: {
vue: {
enabled: true,
compiler: 'vue-template-compiler',
},
diagnosticOptions: {
semantic: true,
syntactic: true,
},
},
formatter: 'codeframe',
}
),
new WorkboxPlugin.GenerateSW({
clientsClaim: true,
skipWaiting: true,
Expand Down