Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maven liquibase execution #22737

Merged
merged 1 commit into from Jul 5, 2023

Conversation

hide212131
Copy link
Contributor

Fixes #19518

Issue fixes for the following problems:

  • No specified version for h2.
  • Outdated version of validator-api.
  • master.xml cannot be detected because its path is not included in the classpath.
  • defaultSchemaName is not passed to pom."

I have a slight concern about the reported vulnerabilities for all versions of h2 (which the vendor claims are not vulnerabilities). While I think it's not a problem since h2 is used only in development (not in production), it might impact the automatic version management in JHipster's pom (would writing it explicitly in pom.xml lead to frequent warnings?).


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@hide212131
Copy link
Contributor Author

Hmm... It's problematic that this issue keeps arising in every review going forward. Is there a good way to avoid this?
review-error

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The dependency review should fail only at dependency introduction (this PR) following PRs should not fail anymore.
I am more concerned about sonar. If sonar pops a security issue we should try to whilelist or drop the fixed version.

@DanielFran DanielFran merged commit 0fa5cc5 into jhipster:main Jul 5, 2023
47 of 48 checks passed
@hide212131 hide212131 deleted the fix-maven-liquibase-execution branch July 5, 2023 22:14
@DanielFran DanielFran added this to the 8.0.0-beta.2 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

liquibase-maven-plugin fails whith liquibase:diff in fresh generated jhipster 7.9.2 project
3 participants