Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract gradle jib config to dedicated conventions plugin #24715

Merged
merged 2 commits into from
Jan 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion generators/server/files.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,12 +311,12 @@ export const baseServerFiles = {
'build.gradle',
'settings.gradle',
'gradle.properties',
'gradle/docker.gradle',
'gradle/profile_dev.gradle',
'gradle/profile_prod.gradle',
'gradle/war.gradle',
'gradle/zipkin.gradle',
`${GRADLE_BUILD_SRC_MAIN_DIR}/jhipster.code-quality-conventions.gradle`,
`${GRADLE_BUILD_SRC_MAIN_DIR}/jhipster.docker-conventions.gradle`,
],
},
{
Expand Down
13 changes: 13 additions & 0 deletions generators/server/generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,11 @@ export default class JHipsterServerGenerator extends BaseApplicationGenerator {
name: 'nohttp-plugin',
version: application.javaDependencies?.['nohttp-checkstyle'],
});
source.addGradleDependencyCatalogVersion?.({ name: 'jib-plugin', version: application.javaDependencies?.['jib-maven-plugin'] });
source.addGradleBuildSrcDependencyCatalogVersion?.({
name: 'jib-plugin',
version: application.javaDependencies?.['jib-maven-plugin'],
});
source.addGradleBuildSrcDependency?.({
groupId: 'org.sonarsource.scanner.gradle',
artifactId: 'sonarqube-gradle-plugin',
Expand Down Expand Up @@ -800,7 +805,15 @@ export default class JHipsterServerGenerator extends BaseApplicationGenerator {
version: '${libs.versions.nohttp.plugin.get()}',
scope: 'implementation',
});
source.addGradleBuildSrcDependency?.({
groupId: 'com.google.cloud.tools',
artifactId: 'jib-gradle-plugin',
// eslint-disable-next-line no-template-curly-in-string
version: '${libs.versions.jib.plugin.get()}',
scope: 'implementation',
});
source.addGradlePlugin?.({ id: 'jhipster.code-quality-conventions' });
source.addGradlePlugin?.({ id: 'jhipster.docker-conventions' });
},
packageJsonScripts({ application }) {
const packageJsonConfigStorage = this.packageJson.createStorage('config').createProxy();
Expand Down
2 changes: 0 additions & 2 deletions generators/server/templates/build.gradle.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ plugins {
id "idea"
id "eclipse"
id "org.springframework.boot"
id "com.google.cloud.tools.jib"
id "com.gorylenko.gradle-git-properties"
<%_ if (enableSwaggerCodegen) { _%>
id "org.openapi.generator"
Expand Down Expand Up @@ -52,7 +51,6 @@ ext {
}
}

apply from: "gradle/docker.gradle"
<%_ if (enableSwaggerCodegen) { _%>
apply from: "gradle/swagger.gradle"
<%_ } _%>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
<%#
Copyright 2013-2023 the original author or authors from the JHipster project.

This file is part of the JHipster project, see https://www.jhipster.tech/
for more information.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

https://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-%>
plugins {
id "jacoco"
id "org.sonarqube"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
See the License for the specific language governing permissions and
limitations under the License.
-%>
plugins {
id "com.google.cloud.tools.jib"
}

jib {
from {
image = "<%- dockerContainers.javaJre %>"
Expand Down Expand Up @@ -46,5 +50,4 @@ jib {
paths = file("<%= dockerServicesDir %>jib")
permissions = ["/entrypoint.sh": "755"]
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ exports[`generator - cassandra gateway-jwt-gradle-enableTranslation(true)-com.pa
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -828,13 +828,13 @@ exports[`generator - cassandra microservice-jwt-reactive(true)-gradle-enableTran
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -1181,13 +1181,13 @@ exports[`generator - cassandra microservice-oauth2-reactive(true)-gradle-enableT
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -1995,13 +1995,13 @@ exports[`generator - cassandra monolith-jwt-reactive(true)-gradle-enableTranslat
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -2725,13 +2725,13 @@ exports[`generator - cassandra monolith-oauth2-reactive(true)-gradle-enableTrans
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -3548,13 +3548,13 @@ exports[`generator - cassandra monolith-session-reactive(true)-gradle-enableTran
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ exports[`generator - couchbase gateway-jwt-gradle-enableTranslation(true)-com.pa
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -852,13 +852,13 @@ exports[`generator - couchbase microservice-jwt-reactive(true)-gradle-enableTran
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -1208,13 +1208,13 @@ exports[`generator - couchbase microservice-oauth2-reactive(true)-gradle-enableT
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -2037,13 +2037,13 @@ exports[`generator - couchbase monolith-jwt-reactive(true)-gradle-enableTranslat
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -2773,13 +2773,13 @@ exports[`generator - couchbase monolith-oauth2-reactive(true)-gradle-enableTrans
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down Expand Up @@ -3617,13 +3617,13 @@ exports[`generator - couchbase monolith-session-reactive(true)-gradle-enableTran
"buildSrc/src/main/groovy/jhipster.code-quality-conventions.gradle": {
"stateCleared": "modified",
},
"checkstyle.xml": {
"buildSrc/src/main/groovy/jhipster.docker-conventions.gradle": {
"stateCleared": "modified",
},
"gradle.properties": {
"checkstyle.xml": {
"stateCleared": "modified",
},
"gradle/docker.gradle": {
"gradle.properties": {
"stateCleared": "modified",
},
"gradle/profile_dev.gradle": {
Expand Down