Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump mysql from 8.2.0 to 8.3.0 #24997

Closed
wants to merge 1 commit into from
Closed

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jan 29, 2024

Fix #24919


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert
Copy link
Contributor Author

@DanielFran @mshima it seems that with 1.19.4 version of org.testcontainers:mysql it works, but I think that applying the version directly in files (like in this PR) is not the good way... WDYT?

@DanielFran
Copy link
Member

@qmonmert we have already defined same version in BOM project, this is strange that it is needed to overwrite here too...

@qmonmert
Copy link
Contributor Author

@DanielFran on JHLite it was related jhipster/jhipster-lite@f0c16c3

@qmonmert
Copy link
Contributor Author

@DanielFran without specify the version #25008

@mshima
Copy link
Member

mshima commented Jan 30, 2024

I think this is a bug at jhipster-bom, it's not overriding correctly the testcontainer-bom.
Maybe because jhipster-bom uses spring-boot-dependencies as parent.

@DanielFran
Copy link
Member

DanielFran commented Jan 30, 2024

I think this is a bug at jhipster-bom, it's not overriding correctly the testcontainer-bom. Maybe because jhipster-bom uses spring-boot-dependencies as parent.

In the past, defining the spring-boot bom then any other after that allow to overwrite any spring-boot dependency.
Starting on some specific maven version the behaviour change and we try to fix it with jhipster/jhipster-bom#1457
Maybe it needs more investigation

@mraible
Copy link
Contributor

mraible commented Feb 1, 2024

It looks like all tests are passing now.

@DanielFran
Copy link
Member

Superseded by #24919

@DanielFran DanielFran closed this Mar 6, 2024
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants