Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't delete all Users in AccountResourceIT #26233

Merged
merged 1 commit into from
May 24, 2024

Conversation

mshima
Copy link
Member

@mshima mshima commented May 23, 2024

Related to #26226.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima force-pushed the user-cleanup2 branch 2 times, most recently from bf11386 to a335021 Compare May 23, 2024 02:45
DanielFran
DanielFran previously approved these changes May 23, 2024
DanielFran
DanielFran previously approved these changes May 23, 2024
@DanielFran DanielFran enabled auto-merge May 23, 2024 12:03
@mshima
Copy link
Member Author

mshima commented May 23, 2024

There is only AccountResourceIT changes and UserResourceIT started failing. UserResourceIT test is dependent on AccountResourceIT behavior for some reason.
It's a bug then, added bug tag to #26226.

@mshima mshima marked this pull request as draft May 23, 2024 12:10
auto-merge was automatically disabled May 23, 2024 12:10

Pull request was converted to draft

@mshima mshima force-pushed the user-cleanup2 branch 2 times, most recently from a548ae0 to 48ebcf8 Compare May 24, 2024 10:47
@mshima mshima marked this pull request as ready for review May 24, 2024 11:39
@DanielFran DanielFran merged commit bb5a70d into jhipster:main May 24, 2024
52 checks passed
@mshima mshima deleted the user-cleanup2 branch May 24, 2024 13:05
@mraible mraible added this to the 8.5.0 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants