add java 22 to README #26495
Merged
add java 22 to README #26495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraible
reviewed
Jun 20, 2024
README.md
Outdated
| | 17 | 18 | ✅ | | ||
| | Java | Node | Status | | ||
| | -------- | ------- | ------ | | ||
| | 17/21/22 | 18/20 | ✅ | |
There was a problem hiding this comment.
Would it be accurate to say 17-21 and 18-20 or do you think it's better to specify the specific versions like you have here?
There was a problem hiding this comment.
I think the old table not accurate, if looks like java 21 is tested with node 20 and java 17 with node 18.
We do have tests in place for java 17/21/22, not 18/19/20. Same for node, so specific versions seems better .
DanielFran
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.