AOT compilation using ngtools/webpack #5907

sendilkumarn · 2017-06-12T07:58:47Z

Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

deepu105

there is a minor mistake.

Dont forget to test prod profile in both maven and gradle

deepu105 · 2017-06-12T08:24:26Z

generators/client/templates/angular/webpack/_webpack.prod.js

+        // AOT Plugin 
+        new AotPlugin({
+            tsConfigPath: './tsconfig-aot.json',
+            entryModule: root('src/main/webapp/app/app.module#HipzeeAppModule')


hardcoded module name!

deepu105 · 2017-06-12T08:24:55Z

generators/client/templates/angular/webpack/_webpack.prod.js

+            comments: false,
+            sourcMap: true,
+            compress: {
+                screw_ie8: true,


sendilkumarn · 2017-06-12T08:28:14Z

@deepu105 prod profile is working
what is that minor mistake expect module name

deepu105 · 2017-06-12T08:39:03Z

module name was the mistake i meant

deepu105 · 2017-06-12T20:02:15Z

generators/client/templates/angular/src/main/webapp/app/_app.main-aot.ts

+-%>
+import { platformBrowser } from '@angular/platform-browser';
+import { ProdConfig } from './blocks/config/prod.config';
+import { <%=angular2AppName%>AppModuleNgFactory } from '../../../../<%= BUILD_DIR %>aot/src/main/webapp/app/app.module.ngfactory';


This might not be available all the time right?

deepu105 · 2017-06-12T20:03:23Z

check failed build

sendilkumarn · 2017-06-14T04:33:42Z

generators/entity/templates/client/angular/src/main/webapp/app/entities/_entity.model.ts

@@ -56,7 +56,7 @@ for (const idx in fields) {
        tsType = 'string';
    } else { //(fieldType === 'byte[]' || fieldType === 'ByteBuffer') && fieldTypeBlobContent == 'any' || (fieldType === 'byte[]' || fieldType === 'ByteBuffer') && fieldTypeBlobContent == 'image' || fieldType == 'LocalDate'
        tsType = 'any';
-        if ((fieldType === 'byte[]' || fieldType === 'ByteBuffer') && fields[idx].fieldTypeBlobContent == 'image') {
+        if ((fieldType === 'byte[]' || fieldType === 'ByteBuffer') && fields[idx].fieldTypeBlobContent !== 'text') {


Interesting, how this was not throwing error so far... 🤔

deepu105 · 2017-06-14T06:30:54Z

There is also issue with the TS entity model class which didnt fail earlier
Error at /home/deepu/workspace/temp/jh4test/target/aot/src/main/webapp/app/entities/product/product-dialog.component.ngfactory.ts:2434:45: Property 'subcategories' does not exist on type 'Product'.
When i changed public subcategory?: SubCategory, to public subcategories?: SubCategory[], it works

its coz of one to many relations declared in singular instead of plural as it appears in DTO or domain
so in _entity.model.ts line 65 to 76 needs to be altered. Now we need to check the relationship type and use proper plural form with type[] for DTO and no DTO cases. refer _entity.java and entityDTO.java

deepu105 · 2017-06-14T06:41:02Z

try this fix

relationships.forEach(relationship => {
    let fieldType;
    let fieldName;
    const relationshipType = relationship.relationshipType;
    if (relationshipType == 'one-to-many' || relationshipType == 'many-to-many') {
        fieldType = `${relationships.otherEntityAngularName}[]`;
        fieldName = relationships.relationshipFieldNamePlural;
    } else {
        if (dto == "no") {
            fieldType = relationships.otherEntityAngularName;
            fieldName = relationships.relationshipFieldName;
        } else {
            fieldType = tsKeyType;
            fieldName = `${relationships.relationshipFieldName}Id`;
        }
    }
    variables[fieldName] = fieldName + '?: ' + fieldType;
});

could also convert the for loop on fields on same file to a forEach?

deepu105 · 2017-06-14T06:43:25Z

ok this fix lets it compile but still I get no screens. I see below error @sendilkumarn can you test it on a clean fresh project?


d66386d….main.bundle.js:1 ERROR Error: Uncaught (in promise): Error: No provider for CookieOptions!
Error: No provider for CookieOptions!
    at injectionError (d66386d….main.bundle.js:1)
    at noProviderError (d66386d….main.bundle.js:1)
    at ReflectiveInjector_._throwOrNull (d66386d….main.bundle.js:1)
    at ReflectiveInjector_._getByKeyDefault (d66386d….main.bundle.js:1)
    at ReflectiveInjector_._getByKey (d66386d….main.bundle.js:1)
    at ReflectiveInjector_.get (d66386d….main.bundle.js:1)
    at Jh4TestAppModuleInjector.get [as _CookieService_135] (d66386d….main.bundle.js:1)
    at Jh4TestAppModuleInjector.get [as _CSRFService_138] (d66386d….main.bundle.js:1)
    at Jh4TestAppModuleInjector.get [as _JhiTrackerService_139] (d66386d….main.bundle.js:1)
    at Jh4TestAppModuleInjector.get [as _Principal_140] (d66386d….main.bundle.js:1)
    at injectionError (d66386d….main.bundle.js:1)
    at noProviderError (d66386d….main.bundle.js:1)
    at ReflectiveInjector_._throwOrNull (d66386d….main.bundle.js:1)
    at ReflectiveInjector_._getByKeyDefault (d66386d….main.bundle.js:1)
    at ReflectiveInjector_._getByKey (d66386d….main.bundle.js:1)
    at ReflectiveInjector_.get (d66386d….main.bundle.js:1)
    at Jh4TestAppModuleInjector.get [as _CookieService_135] (d66386d….main.bundle.js:1)
    at Jh4TestAppModuleInjector.get [as _CSRFService_138] (d66386d….main.bundle.js:1)
    at Jh4TestAppModuleInjector.get [as _JhiTrackerService_139] (d66386d….main.bundle.js:1)
    at Jh4TestAppModuleInjector.get [as _Principal_140] (d66386d….main.bundle.js:1)
    at resolvePromise (d66386d….polyfills.bundle.js:1)
    at resolvePromise (d66386d….polyfills.bundle.js:1)
    at d66386d….polyfills.bundle.js:1
    at ZoneDelegate.invokeTask (d66386d….polyfills.bundle.js:1)
    at Object.onInvokeTask (d66386d….main.bundle.js:1)
    at ZoneDelegate.invokeTask (d66386d….polyfills.bundle.js:1)
    at Zone.runTask (d66386d….polyfills.bundle.js:1)
    at drainMicroTaskQueue (d66386d….polyfills.bundle.js:1)
    at <anonymous>

deepu105 · 2017-06-14T08:27:43Z

generators/entity/templates/client/angular/src/main/webapp/app/entities/_entity.model.ts

    } else {
-        fieldType = tsKeyType;
-        fieldName = relationships[idx].relationshipFieldName + "Id";
+        if (dto == "no") {


ahh dto === 'no' plz i missed it

@sendilkumarn

deepu105 · 2017-06-14T09:12:04Z

protractor tests still failing probably same error as above when running in prod profile

deepu105 · 2017-06-14T09:13:15Z

btw also rebase with current master

deepu105 · 2017-06-18T13:45:10Z

@sendilkumarn are you stuck? do you need help? we really need this to proceed with #4794

thomas-burko · 2017-06-18T18:57:54Z

generators/client/templates/angular/webpack/_webpack.prod.js

+        new webpack.optimize.UglifyJsPlugin({
+            beautify: false,
+            comments: false,
+            sourcMap: true,


deepu105 · 2017-06-19T12:06:51Z

@sendilkumarn @jdubois I had to revert this PR as its causing some sort of infinite loop in ngc phase

deepu105 · 2017-06-19T12:07:10Z

I'll create a new branch and PR to work on this

sendilkumarn changed the title ~~aot~~ AOT compilation using ngtools/webpack Jun 12, 2017

deepu105 requested changes Jun 12, 2017

View reviewed changes

deepu105 reviewed Jun 12, 2017

View reviewed changes

deepu105 approved these changes Jun 12, 2017

View reviewed changes

sendilkumarn closed this Jun 14, 2017

sendilkumarn reopened this Jun 14, 2017

sendilkumarn commented Jun 14, 2017

View reviewed changes

sendilkumarn force-pushed the aot2 branch from b43a615 to 1f66efa Compare June 14, 2017 05:41

sendilkumarn mentioned this pull request Jun 14, 2017

Angular 2 TODO for next #4794

Closed

21 tasks

deepu105 reviewed Jun 14, 2017

View reviewed changes

sendilkumarn added 7 commits June 17, 2017 11:51

aot

145adba

linting

f8ef65e

fixing module name

db6992b

fixing travis issue

f07b07d

fixing travis issues

e25689a

plural fixes

500f15e

fixing issues

1f81e96

sendilkumarn force-pushed the aot2 branch from 802ed12 to 1f81e96 Compare June 17, 2017 03:56

thomas-burko reviewed Jun 18, 2017

View reviewed changes

deepu105 merged commit 1f81e96 into jhipster:master Jun 19, 2017

jdubois modified the milestone: 4.5.5 Jun 19, 2017

sendilkumarn deleted the aot2 branch October 21, 2020 17:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AOT compilation using ngtools/webpack #5907

AOT compilation using ngtools/webpack #5907

sendilkumarn commented Jun 12, 2017 •

edited by deepu105

deepu105 left a comment

deepu105 Jun 12, 2017

deepu105 Jun 12, 2017

sendilkumarn commented Jun 12, 2017 •

edited

deepu105 commented Jun 12, 2017

deepu105 Jun 12, 2017

deepu105 commented Jun 12, 2017

sendilkumarn Jun 14, 2017 •

edited

deepu105 commented Jun 14, 2017

deepu105 commented Jun 14, 2017 •

edited

deepu105 commented Jun 14, 2017

deepu105 Jun 14, 2017

deepu105 Jun 14, 2017

deepu105 commented Jun 14, 2017

deepu105 commented Jun 14, 2017

deepu105 commented Jun 18, 2017

thomas-burko Jun 18, 2017

deepu105 commented Jun 19, 2017

deepu105 commented Jun 19, 2017

AOT compilation using ngtools/webpack #5907

AOT compilation using ngtools/webpack #5907

Conversation

sendilkumarn commented Jun 12, 2017 • edited by deepu105

deepu105 left a comment

Choose a reason for hiding this comment

deepu105 Jun 12, 2017

Choose a reason for hiding this comment

deepu105 Jun 12, 2017

Choose a reason for hiding this comment

sendilkumarn commented Jun 12, 2017 • edited

deepu105 commented Jun 12, 2017

deepu105 Jun 12, 2017

Choose a reason for hiding this comment

deepu105 commented Jun 12, 2017

sendilkumarn Jun 14, 2017 • edited

Choose a reason for hiding this comment

deepu105 commented Jun 14, 2017

deepu105 commented Jun 14, 2017 • edited

deepu105 commented Jun 14, 2017

deepu105 Jun 14, 2017

Choose a reason for hiding this comment

deepu105 Jun 14, 2017

Choose a reason for hiding this comment

deepu105 commented Jun 14, 2017

deepu105 commented Jun 14, 2017

deepu105 commented Jun 18, 2017

thomas-burko Jun 18, 2017

Choose a reason for hiding this comment

deepu105 commented Jun 19, 2017

deepu105 commented Jun 19, 2017

sendilkumarn commented Jun 12, 2017 •

edited by deepu105

sendilkumarn commented Jun 12, 2017 •

edited

sendilkumarn Jun 14, 2017 •

edited

deepu105 commented Jun 14, 2017 •

edited