Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging for Microservices #6742

Merged

Conversation

pascalgrimaud
Copy link
Member

I hope it will fix #6741


  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@deepu105 deepu105 merged commit 6769089 into jhipster:master Nov 26, 2017
@deepu105
Copy link
Member

The build passed. I checked the logs. We need to see why the build was green for this case earlier

@pascalgrimaud
Copy link
Member Author

pascalgrimaud commented Nov 26, 2017 via email

@jdubois jdubois added this to the 4.11.1 milestone Nov 26, 2017
@erikkemperman
Copy link
Member

Sorry guys, this was my fault! Any idea yet why Travis passed despite this error?

@pascalgrimaud
Copy link
Member Author

No worry.

Travis passed because:

  • mvnw package generated a war and exit 0 (instead of another number), although there is a failure in the build process
  • the war is generated but it is corrupted
  • there was no curl on Microservices, to test if the microservice started correctly, fixed by Travis: curl Microservices #6749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.11.0 : Building a production War with Maven fails for microservices
4 participants