New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Lazy load admin module #7235
Merged
deepu105
merged 9 commits into
jhipster:master
from
wmarques:lazy-load-admin-without-ngtools
Mar 12, 2018
Merged
Angular: Lazy load admin module #7235
deepu105
merged 9 commits into
jhipster:master
from
wmarques:lazy-load-admin-without-ngtools
Mar 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made a patch release for ng-jhipster plz use v0.4.2
Thanks & Regards,
Deepu
…On Tue, Mar 6, 2018 at 12:14 AM, William Marques ***@***.***> wrote:
While we discuss on the ngtools/webpack usage on #7231
<#7231>, I used the
angular-router-loader to make the lazy loading work with at-loader.
However I need a ng-jhipster release with the removal of HttpClient,
otherwise the interceptors won't be shared with the lazy loaded modules.
-
Please make sure the below checklist is followed for Pull Requests.
-
Travis tests
<https://travis-ci.org/jhipster/generator-jhipster/pull_requests> are
green
-
Tests are added where necessary
-
Documentation is added/updated where necessary
-
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document
<https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md>
are followed
------------------------------
You can view, comment on, or merge this pull request online at:
#7235
Commit Summary
- Lazy load admin module
- Remove adminModule from AppModule
- Import HttpClientModule once in CoreModule
- Update admin routes links in navbar
- fix missing @
- Use angular-router-loader to lazy load in dev
- Remove contextReplacement to allow lazy load in prod
File Changes
- *M* generators/client/templates/angular/package.json.ejs
<https://github.com/jhipster/generator-jhipster/pull/7235/files#diff-0>
(3)
- *M* generators/client/templates/angular/src/main/webapp/app/
app-routing.module.ts.ejs
<https://github.com/jhipster/generator-jhipster/pull/7235/files#diff-1>
(11)
- *M* generators/client/templates/angular/src/main/webapp/app/
app.module.ts.ejs
<https://github.com/jhipster/generator-jhipster/pull/7235/files#diff-2>
(2)
- *M* generators/client/templates/angular/src/main/webapp/app/
core/core.module.ts.ejs
<https://github.com/jhipster/generator-jhipster/pull/7235/files#diff-3>
(5)
- *M* generators/client/templates/angular/src/main/webapp/app/
layouts/navbar/navbar.component.html.ejs
<https://github.com/jhipster/generator-jhipster/pull/7235/files#diff-4>
(18)
- *M* generators/client/templates/angular/src/main/webapp/app/
shared/shared-libs.module.ts.ejs
<https://github.com/jhipster/generator-jhipster/pull/7235/files#diff-5>
(2)
- *M* generators/client/templates/angular/webpack/webpack.common.js.ejs
<https://github.com/jhipster/generator-jhipster/pull/7235/files#diff-6>
(7)
- *M* generators/client/templates/angular/webpack/webpack.dev.js.ejs
<https://github.com/jhipster/generator-jhipster/pull/7235/files#diff-7>
(3)
Patch Links:
- https://github.com/jhipster/generator-jhipster/pull/7235.patch
- https://github.com/jhipster/generator-jhipster/pull/7235.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7235>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ABDlFyO6Tkdfnln_zsZKnF6NdTXAXmIXks5tbcbkgaJpZM4Sd1SI>
.
|
wmarques
force-pushed
the
lazy-load-admin-without-ngtools
branch
from
March 8, 2018 22:57
3fe574a
to
ef185f0
Compare
Tests finally passed 😄 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we discuss on the ngtools/webpack usage on #7231, I used the angular-router-loader to make the lazy loading work with at-loader.
However I need a ng-jhipster release with the removal of HttpClient, otherwise the interceptors won't be shared with the lazy loaded modules.
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed