Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Lazy load admin module #7235

Merged
merged 9 commits into from Mar 12, 2018

Conversation

wmarques
Copy link
Contributor

@wmarques wmarques commented Mar 5, 2018

While we discuss on the ngtools/webpack usage on #7231, I used the angular-router-loader to make the lazy loading work with at-loader.
However I need a ng-jhipster release with the removal of HttpClient, otherwise the interceptors won't be shared with the lazy loaded modules.

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@deepu105
Copy link
Member

deepu105 commented Mar 6, 2018 via email

@wmarques wmarques force-pushed the lazy-load-admin-without-ngtools branch from 3fe574a to ef185f0 Compare March 8, 2018 22:57
@deepu105 deepu105 added the v5 label Mar 9, 2018
@deepu105 deepu105 added this to In progress in JHipster 5 Mar 9, 2018
@wmarques
Copy link
Contributor Author

Tests finally passed 😄

@deepu105 deepu105 merged commit 95c7fc9 into jhipster:master Mar 12, 2018
JHipster 5 automation moved this from In progress to Done Mar 12, 2018
@jdubois jdubois added this to the 5.0.0-beta.0 milestone Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
JHipster 5
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants