New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Angular 6 #7582
Upgrade to Angular 6 #7582
Conversation
Seems that we cannot use a custom webpack build with angular-cli... When I try to |
I don't know how to be still angular CLI compliant, it always generate the component under a wrong path even if I specifiy |
@wmarques that seems weird, |
@wmarques lets list the issues that we have currently on this probably in a doc, what say? |
@sendilkumarn Yes, strange... If you guys have any idea about adapting the angular.json file to make it work.. |
a356304
to
be31ea8
Compare
@sendilkumarn I just rebased, let's wait for Travis and if you are ok with this you can merge |
Let me rebase again, the travis build fails doesn't seem related to my PR... |
be31ea8
to
1099999
Compare
Finally green 🎉 |
I think we can merge this if this is ok for you guys and I'll start migrating on the new DI injection system on a next PR, we also need the ng-jhipster lib to migrate |
Congrats @wmarques for the hard work ! |
Well I had enough time to move to the new Dependency Injection so I merged my work on this PR, let me know if you have any feedbacks |
Travis back to red since your last commit, sorry @wmarques |
@pascalgrimaud it's probably my fault, it's corrected now, @wmarques can you rebase? |
374d1e0
to
3c3a4b8
Compare
This looks all good, let's merge it as this can't be in a separate branch for long (we'll get lots of conflicts) |
@wmarques great work 👏 It would be awesome to get the stats after this |
@wmarques just one issue: when you do some responsive tests (putting the app in a small window, in fact), the menu doesn't show up :-( |
@wmarques does the new DI affect lazy loading? Since many services are in root now? |
@deepu105 I analyzed the generated bundle and it seems that if the module is lazy loaded Angular puts the injected services in this module in the correct bundle so I didn't see any changes in the output. |
Still WIP, need to check if I correctly migrated the rxjs imports.
I wanted to remove the
rxjs-compat
dependency but some libs aren't rxjs6 compliant (ngx-webstorage, ngx-infinite-scroll)...TODO:
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed