Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maven elasticsearch missing dependencies #8749

Merged
merged 2 commits into from Nov 5, 2018

Conversation

ruddell
Copy link
Member

@ruddell ruddell commented Nov 4, 2018

Maven projects using Elasticsearch fail to start without these dependencies.

Pinging @Tcharl since they may know a better way to fix this (these dependencies were removed in #8475). I don't notice anything wrong when adding these dependencies back to the pom.xml.

related to #8739

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@jdubois
Copy link
Member

jdubois commented Nov 4, 2018

Sorry I missed this - should I do an emergency patch request tomorrow?

@ruddell
Copy link
Member Author

ruddell commented Nov 4, 2018

If you have time it would be good

@jdubois
Copy link
Member

jdubois commented Nov 4, 2018

Thanks! I'll try tomorrow

@DanielFran
Copy link
Member

@ruddel Is this needed to explicitly define the version?

@ruddell
Copy link
Member Author

ruddell commented Nov 4, 2018

@DanielFran It fails in dev if I remove the specific versions:
{"root_cause":[{"type":"class_cast_exception","reason":"org.apache.logging.slf4j.SLF4JLoggerContext cannot be cast to org.apache.logging.log4j.core.LoggerContext"}],"type":"class_cast_exception","reason":"org.apache.logging.slf4j.SLF4JLoggerContext cannot be cast to org.apache.logging.log4j.core.LoggerContext"}

@DanielFran
Copy link
Member

DanielFran commented Nov 4, 2018

From @Tcharl 's PR, he added the mapstruct + log4j dependencies in jhipster-bom project but then remove it since it was failing... He probably forget to rollback changes on generator-jhipster project.

And current logj2 version is 2.10.0 with spring-boot 2.0.6.
Also slf4j version 1.7.25.

@DanielFran
Copy link
Member

DanielFran commented Nov 4, 2018

Probably missing the bidding between slf4j to log4j dependency: https://logging.apache.org/log4j/2.0/log4j-slf4j-impl/

Validated the starter-data-jest and the log4j dependency is only defined for testing... Seems an issue with dependencies!
@VanRoy maybe related with VanRoy/spring-data-jest#90 and VanRoy/spring-data-jest#95

@pascalgrimaud
Copy link
Member

Do we have the issue with Gradle too ?
@ruddell : is it only for dev profile, right ? That explains why our CI didn't detect it

@ruddell
Copy link
Member Author

ruddell commented Nov 5, 2018

The dependencies are still in the gradle file here

And yes it only affects dev

@jdubois
Copy link
Member

jdubois commented Nov 5, 2018

Hi everyone, I understand this isn't a perfect solution, but let's first fix this and then try to improve. I'm merging this and I'll try to do a release today.

@jdubois jdubois merged commit 64cfe03 into jhipster:master Nov 5, 2018
@jdubois jdubois added this to the 5.6.1 milestone Nov 5, 2018
@ruddell ruddell deleted the es-missing-deps branch November 5, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants