New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix maven elasticsearch missing dependencies #8749
Conversation
Sorry I missed this - should I do an emergency patch request tomorrow? |
If you have time it would be good |
Thanks! I'll try tomorrow |
@ruddel Is this needed to explicitly define the version? |
@DanielFran It fails in dev if I remove the specific versions: |
From @Tcharl 's PR, he added the mapstruct + log4j dependencies in jhipster-bom project but then remove it since it was failing... He probably forget to rollback changes on generator-jhipster project. And current logj2 version is 2.10.0 with spring-boot 2.0.6. |
Probably missing the bidding between slf4j to log4j dependency: https://logging.apache.org/log4j/2.0/log4j-slf4j-impl/ Validated the starter-data-jest and the log4j dependency is only defined for testing... Seems an issue with dependencies! |
Do we have the issue with Gradle too ? |
The dependencies are still in the gradle file here And yes it only affects |
Hi everyone, I understand this isn't a perfect solution, but let's first fix this and then try to improve. I'm merging this and I'll try to do a release today. |
Maven projects using Elasticsearch fail to start without these dependencies.
Pinging @Tcharl since they may know a better way to fix this (these dependencies were removed in #8475). I don't notice anything wrong when adding these dependencies back to the pom.xml.
related to #8739
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed