-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump angular dependencies #9825
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
197454c
Bump angular dependencies
vishal423 341cadd
revert ngx-cookie upgrade and fix health check tests
vishal423 236ab0c
Update corejs, e2e dependencies, and removed storage mocks
vishal423 65146f0
Update cache loader
vishal423 bccc305
Revert ng-bootstrap to old version
vishal423 0ef1e00
Disable cli analytics
vishal423 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,129 +27,129 @@ | |
"node_modules" | ||
], | ||
"dependencies": { | ||
"@angular/common": "7.2.12", | ||
"@angular/compiler": "7.2.12", | ||
"@angular/core": "7.2.12", | ||
"@angular/forms": "7.2.12", | ||
"@angular/platform-browser": "7.2.12", | ||
"@angular/platform-browser-dynamic": "7.2.12", | ||
"@angular/router": "7.2.12", | ||
"@fortawesome/angular-fontawesome": "0.3.0", | ||
"@fortawesome/fontawesome-svg-core": "1.2.17", | ||
"@fortawesome/free-solid-svg-icons": "5.8.1", | ||
"@ng-bootstrap/ng-bootstrap": "4.1.1", | ||
"@angular/common": "8.0.0", | ||
"@angular/compiler": "8.0.0", | ||
"@angular/core": "8.0.0", | ||
"@angular/forms": "8.0.0", | ||
"@angular/platform-browser": "8.0.0", | ||
"@angular/platform-browser-dynamic": "8.0.0", | ||
"@angular/router": "8.0.0", | ||
"@fortawesome/angular-fontawesome": "0.4.0", | ||
"@fortawesome/fontawesome-svg-core": "1.2.18", | ||
"@fortawesome/free-solid-svg-icons": "5.8.2", | ||
"@ng-bootstrap/ng-bootstrap": "4.1.3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In Reverting to version before that works fine. |
||
"@ngx-translate/core": "11.0.1", | ||
"@ngx-translate/http-loader": "4.0.0", | ||
"bootstrap": "4.3.1", | ||
<%_ if (clientTheme !== 'none') { _%> | ||
"bootswatch": "4.3.1", | ||
<%_ } _%> | ||
"core-js": "2.6.5", | ||
"core-js": "3.1.3", | ||
"moment": "2.24.0", | ||
"ng-jhipster": "0.9.3", | ||
"ngx-cookie": "4.0.2", | ||
"ngx-infinite-scroll": "7.1.0", | ||
"ngx-webstorage": "3.0.2", | ||
"rxjs": "6.4.0", | ||
"ngx-webstorage": "4.0.0", | ||
"rxjs": "6.5.2", | ||
"swagger-ui": "2.2.10", | ||
<%_ if (websocket === 'spring-websocket') { _%> | ||
"sockjs-client": "1.3.0", | ||
"webstomp-client": "1.2.6", | ||
<%_ } _%> | ||
"tslib": "1.9.3", | ||
"zone.js": "0.8.29" | ||
"zone.js": "0.9.1" | ||
}, | ||
"devDependencies": { | ||
"@angular/cli": "7.3.8", | ||
"@angular/compiler-cli": "7.2.12", | ||
"@ngtools/webpack": "7.3.8", | ||
"@angular/cli": "8.0.0", | ||
"@angular/compiler-cli": "8.0.0", | ||
"@ngtools/webpack": "8.0.0", | ||
<%_ if (protractorTests) { _%> | ||
"@types/chai": "4.1.7", | ||
"@types/chai-string": "1.4.1", | ||
<%_ } _%> | ||
"@types/jest": "24.0.11", | ||
"@types/jest": "24.0.13", | ||
<%_ if (protractorTests) { _%> | ||
"@types/mocha": "5.2.6", | ||
<%_ } _%> | ||
"@types/node": "10.12.27", | ||
<%_ if (protractorTests) { _%> | ||
"@types/selenium-webdriver": "3.0.15", | ||
"@types/selenium-webdriver": "4.0.0", | ||
<%_ } _%> | ||
"angular-router-loader": "0.8.5", | ||
"angular2-template-loader": "0.6.2", | ||
"autoprefixer": "9.5.0", | ||
"autoprefixer": "9.5.1", | ||
"base-href-webpack-plugin": "2.0.0", | ||
"browser-sync": "2.26.5", | ||
"browser-sync-webpack-plugin": "2.2.2", | ||
"cache-loader": "2.0.1", | ||
"cache-loader": "3.0.1", | ||
<%_ if (protractorTests) { _%> | ||
"chai": "4.2.0", | ||
"chai-as-promised": "7.1.1", | ||
"chai-string": "1.5.0", | ||
<%_ } _%> | ||
"codelyzer": "5.0.0", | ||
"copy-webpack-plugin": "5.0.2", | ||
"codelyzer": "5.0.1", | ||
"copy-webpack-plugin": "5.0.3", | ||
"css-loader": "2.1.1", | ||
"file-loader": "3.0.1", | ||
"fork-ts-checker-webpack-plugin": "1.0.1", | ||
"fork-ts-checker-webpack-plugin": "1.3.4", | ||
"friendly-errors-webpack-plugin": "1.7.0", | ||
"generator-jhipster": "<%= packagejs.version %>", | ||
"html-loader": "0.5.5", | ||
"html-webpack-plugin": "3.2.0", | ||
<%_ if (!skipCommitHook) { _%> | ||
"husky": "1.3.1", | ||
"husky": "2.3.0", | ||
<%_ } _%> | ||
"jest": "24.7.1", | ||
"jest-junit": "6.3.0", | ||
"jest-preset-angular": "7.0.1", | ||
"jest": "24.8.0", | ||
"jest-junit": "6.4.0", | ||
"jest-preset-angular": "7.1.1", | ||
"jest-sonar-reporter": "2.0.0", | ||
<%_ if (!skipCommitHook) { _%> | ||
"lint-staged": "8.1.5", | ||
"lint-staged": "8.1.7", | ||
<%_ } _%> | ||
<%_ if (enableTranslation) { _%> | ||
"merge-jsons-webpack-plugin": "1.0.18", | ||
"merge-jsons-webpack-plugin": "1.0.19", | ||
<%_ } _%> | ||
"mini-css-extract-plugin": "0.5.0", | ||
"mini-css-extract-plugin": "0.7.0", | ||
<%_ if (protractorTests) { _%> | ||
"mocha": "6.1.4", | ||
<%_ } _%> | ||
"moment-locales-webpack-plugin": "1.0.7", | ||
"optimize-css-assets-webpack-plugin": "5.0.1", | ||
"postcss-loader": "3.0.0", | ||
"prettier": "1.16.4", | ||
"prettier": "1.17.1", | ||
<%_ if (protractorTests) { _%> | ||
"protractor": "5.4.2", | ||
<%_ } _%> | ||
"reflect-metadata": "0.1.13", | ||
"rimraf": "2.6.3", | ||
"sass": "1.17.4", | ||
"sass": "1.20.1", | ||
"sass-loader": "7.1.0", | ||
"simple-progress-webpack-plugin": "1.1.2", | ||
"style-loader": "0.23.1", | ||
"terser-webpack-plugin": "1.2.3", | ||
"terser-webpack-plugin": "1.3.0", | ||
"thread-loader": "2.1.2", | ||
"to-string-loader": "1.1.5", | ||
"ts-loader": "5.3.3", | ||
"ts-loader": "6.0.1", | ||
<%_ if (protractorTests) { _%> | ||
"ts-node": "8.0.3", | ||
"ts-node": "8.2.0", | ||
<%_ } _%> | ||
"tslint": "5.15.0", | ||
"tslint": "5.16.0", | ||
"tslint-config-prettier": "1.18.0", | ||
"tslint-loader": "3.5.4", | ||
"typescript": "3.2.4", | ||
"typescript": "3.4.5", | ||
<%_ otherModules.forEach(module => { _%> | ||
"<%= module.name %>": "<%= module.version %>", | ||
<%_ }); _%> | ||
<%_ if (protractorTests) { _%> | ||
"webdriver-manager": "12.1.4", | ||
<%_ } _%> | ||
"webpack": "4.29.6", | ||
"webpack-cli": "3.3.0", | ||
"webpack-dev-server": "3.2.1", | ||
"webpack": "4.32.2", | ||
"webpack-cli": "3.3.2", | ||
"webpack-dev-server": "3.4.1", | ||
"webpack-merge": "4.2.1", | ||
"webpack-notifier": "1.7.0", | ||
"webpack-visualizer-plugin": "0.1.11", | ||
"workbox-webpack-plugin": "3.6.3", | ||
"workbox-webpack-plugin": "4.3.1", | ||
"write-file-webpack-plugin": "4.5.0"<% if (buildTool === 'maven') { %>, | ||
"xml2js": "0.4.19" | ||
<%_ } _%> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
generators/client/templates/angular/src/test/javascript/jest-global-mocks.ts.ejs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,3 @@ | ||
const mock = () => { | ||
let storage = {}; | ||
return { | ||
getItem: key => (key in storage ? storage[key] : null), | ||
setItem: (key, value) => (storage[key] = value || ''), | ||
removeItem: key => delete storage[key], | ||
clear: () => (storage = {}) | ||
}; | ||
}; | ||
|
||
Object.defineProperty(window, 'localStorage', { value: mock() }); | ||
Object.defineProperty(window, 'sessionStorage', { value: mock() }); | ||
vishal423 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Object.defineProperty(window, 'getComputedStyle', { | ||
value: () => ['-webkit-appearance'] | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishal423 : can you explain me what is it plz ? Maybe we need to add this to Azure Pipelines too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Angular CLI added an analytics feature (like us), this env variable prevents from sending data usage to the CLI project.
I don't think we need to add it into our pipeline as we don't rely on the angular CLI to build our application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In absence of this option, Travis builds got stuck in the post-install scripts (failed build logs @ https://travis-ci.org/jhipster/generator-jhipster/builds/539685496). I haven't noticed this issue on the Azure build pipleines (not sure why such discrepancy).