Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

Add the possibility to allow blueprints to add custom keywords #448

Closed
MathieuAA opened this issue Apr 2, 2020 · 5 comments
Closed

Add the possibility to allow blueprints to add custom keywords #448

MathieuAA opened this issue Apr 2, 2020 · 5 comments
Assignees
Labels
blueprints $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/

Comments

@MathieuAA
Copy link
Member

For instance, for the VueJS blueprint, it can add the clientFramework value vuejs

@pascalgrimaud this one deserves a bounty

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Apr 2, 2020
@mshima
Copy link
Member

mshima commented Apr 5, 2020

@MathieuAA are you working on this one?
I can give a try.

@MathieuAA
Copy link
Member Author

The need for this GH issue is this: I'm a blueprint dev and I don't want the JDL parsing system to throw an error if the JDL content contains any value (option value, app value, anything a blueprint can add) related to the blueprint.
A simple example so that you get the full picture: the vuejs blueprint adds the "vuejs" (or Vue, I don't remember) app value for the "client framework" option. Pierre had to add the string as a valid value back then, but this isn't a good solution as you can guess...

The issue is a possible solution, but it's not definitive. I'm working on the "add the blueprints keyword" right now, and this issue may or may not be relevant after adding the keyword.
All ideas are welcome.

@mshima
Copy link
Member

mshima commented Apr 5, 2020

I started to implement this one, because I had an idea on how to implement it.
The concept is done.
I will created a draft PR to you take a look.
If this is already in progress, then I will close it.

@mshima
Copy link
Member

mshima commented Apr 5, 2020

The blueprint jdl will be loaded like I did at jhipster/generator-jhipster#11337.

I recommend that the blueprint config should be versioned.

@MathieuAA
Copy link
Member Author

Alright I'll have a look then!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blueprints $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants