This repository has been archived by the owner on Mar 21, 2021. It is now read-only.
Add returnMergedEntity option #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuAA
suggested changes
Mar 13, 2020
MathieuAA
suggested changes
Mar 13, 2020
mshima
force-pushed
the
master
branch
2 times, most recently
from
2fcd069
to
3bf72ea
Compare
MathieuAA
suggested changes
Mar 13, 2020
|
Can you finish this PR please @mshima? |
|
@MathieuAA sure. I will try later today. |
|
Probably I will split in smaller PRs. |
|
Thanks :) Do as you please! |
mshima
force-pushed
the
master
branch
2 times, most recently
from
281eb88
to
122d30b
Compare
|
@MathieuAA first round is ready. |
|
Can we close this one then? |
There are 2 more changes. |
mshima
force-pushed
the
master
branch
2 times, most recently
from
eee8bf3
to
9bbcb32
Compare
mshima
changed the title
|
@MathieuAA this is the last one for now. |
MathieuAA
suggested changes
Mar 28, 2020
|
I just noticed that the only method that take subFolder (application.name) into account is writeEntities. |
MathieuAA
approved these changes
Apr 5, 2020
@mshima sorry didn't see your comment... Anyway, this is good to go, thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.