-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .net7 #1330
Update .net7 #1330
Conversation
Thanks for the PR. I'll take a look at it soon |
generators/client/templates/blazor/test/Project.Client.Test/AlertErrorTest.cs.ejs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice ! I'm excited to test this =)
generators/server/templates/dotnetcore/src/Project/Configuration/DatabaseStartup.cs.ejs
Outdated
Show resolved
Hide resolved
LGTM, @ivanmonteiro if it's ok for you we can merge it |
LGTM, @nicolas63 you can merge it And thank you @123445666 for your PR |
Can you update the version of JHipsterNet.Core to 1.0.9 and after that i can merge it |
Hi @nicolas63, I think jhipster.net v1.0.9 on nuget is for .net6, do you think we should increase version for it, don't you? |
Sorry it's my bad in the jhipster-net the update is manual here https://github.com/jhipster/jhipster-net/blob/main/.github/workflows/buildandpublish.yml#L25 Can you update to 1.0.10 ? |
Done |
Kudos, SonarCloud Quality Gate passed! |
everythings is good ! thanks @123445666 |
This Pull Request include:
Update .Net 7
Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed
resolved #1223