Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .net7 #1330

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Update .net7 #1330

merged 4 commits into from
Apr 10, 2023

Conversation

123445666
Copy link
Contributor

This Pull Request include:

  • Update .Net 7

  • Please make sure the below checklist is followed for Pull Requests.

  • All continuous integration tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

resolved #1223

@ivanmonteiro
Copy link
Contributor

Thanks for the PR. I'll take a look at it soon

Copy link
Member

@nicolas63 nicolas63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ! I'm excited to test this =)

@nicolas63
Copy link
Member

LGTM, @ivanmonteiro if it's ok for you we can merge it

@ivanmonteiro
Copy link
Contributor

LGTM, @ivanmonteiro if it's ok for you we can merge it

LGTM, @nicolas63 you can merge it

And thank you @123445666 for your PR

@nicolas63
Copy link
Member

Can you update the version of JHipsterNet.Core to 1.0.9 and after that i can merge it

@123445666
Copy link
Contributor Author

Hi @nicolas63, I think jhipster.net v1.0.9 on nuget is for .net6, do you think we should increase version for it, don't you?
And in the jhipster-dotnetcore, I saw the library jhipster core doesn't have the version, I will rêchck about this.

@nicolas63
Copy link
Member

Hi @nicolas63, I think jhipster.net v1.0.9 on nuget is for .net6, do you think we should increase version for it, don't you?
And in the jhipster-dotnetcore, I saw the library jhipster core doesn't have the version, I will rêchck about this.

Sorry it's my bad in the jhipster-net the update is manual here https://github.com/jhipster/jhipster-net/blob/main/.github/workflows/buildandpublish.yml#L25

Can you update to 1.0.10 ?

@123445666
Copy link
Contributor Author

Hi @nicolas63, I think jhipster.net v1.0.9 on nuget is for .net6, do you think we should increase version for it, don't you?
And in the jhipster-dotnetcore, I saw the library jhipster core doesn't have the version, I will rêchck about this.

Sorry it's my bad in the jhipster-net the update is manual here https://github.com/jhipster/jhipster-net/blob/main/.github/workflows/buildandpublish.yml#L25

Can you update to 1.0.10 ?

Done

@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nicolas63
Copy link
Member

everythings is good ! thanks @123445666

@nicolas63 nicolas63 merged commit be9371f into jhipster:main Apr 10, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to .NET 7
3 participants