Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial playwright configuration #1322

Merged
merged 3 commits into from Apr 16, 2022
Merged

add initial playwright configuration #1322

merged 3 commits into from Apr 16, 2022

Conversation

atomfrede
Copy link
Member

Initial playwright configuration with one spec and page object model.

closes #1296

@atomfrede
Copy link
Member Author

Will check the code smells tomorrow. And of course, as we talked about it this morning, sonar images are not available as arm64. So much for no problems with M1 macs and docker :)

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1322 (4b66c06) into main (aa6f27c) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1322   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1557      1577   +20     
===========================================
  Files            296       301    +5     
  Lines           5034      5081   +47     
  Branches          90        90           
===========================================
+ Hits            5034      5081   +47     
Impacted Files Coverage Δ
...astructure/primary/rest/FrontendMavenResource.java 100.00% <ø> (ø)
...ight/application/PlaywrightApplicationService.java 100.00% <100.00%> (ø)
...tor/client/tools/playwright/domain/Playwright.java 100.00% <100.00%> (ø)
...ols/playwright/domain/PlaywrightDomainService.java 100.00% <100.00%> (ø)
...astructure/config/PlaywrightBeanConfiguration.java 100.00% <100.00%> (ø)
...ght/infrastructure/primary/PlaywrightResource.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a7e06...4b66c06. Read the comment docs.

@pascalgrimaud
Copy link
Member

Impressive work @atomfrede !
You're so fast lol

I'll review it soon :)

@pascalgrimaud
Copy link
Member

I think the front is stable now, so in another PRs, we can add this to the front part:

  • front: secondary with api
  • front: primary + the button in Vue page

@pascalgrimaud pascalgrimaud merged commit 8636b58 into jhipster:main Apr 16, 2022
@atomfrede
Copy link
Member Author

@pascalgrimaud
Copy link
Member

@atomfrede : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add playwright as additional e2e framework
2 participants