[Angular] Add Angular Material #1556
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1556 +/- ##
============================================
Coverage 100.00% 100.00%
- Complexity 1609 1646 +37
============================================
Files 331 350 +19
Lines 5467 5814 +347
Branches 110 141 +31
============================================
+ Hits 5467 5814 +347
Continue to review full report at Codecov.
|
| @@ -81,31 +81,32 @@ public void addJwtDependencies(Project project) { | |||
| } | |||
|
|
|||
| public void updateAngularFilesForJwt(Project project) { | |||
| String oldHtml = "<router-outlet></router-outlet>"; | |||
| String oldHtml = "<div id=\"footer\">"; | |||
There was a problem hiding this comment.
Hi,
Little question about the old/new html replacement.
Why don't you had a specific comment to replace when you want to add some template code instead ?
I'm asking because the footer is also added at the end of new html ?
Thanks :)
There was a problem hiding this comment.
hi, indeed it will be a good idea to have a specific comment but this comment will be strange when we don't replace it!
There was a problem hiding this comment.
I think it depends of comment meaning.
If you have something as -- jhipster-needle-extra-template which explains it used by generator to add extra info it could be understood. For sure once the project is done the user can delete it.
However, if for now you can add/replace only once from generator indeed it's not maybe necessary.
As you prefer :)
|
I'm starting to review this PR @qmonmert |
|
@pascalgrimaud ok good, I think the idea of @seraphinandrieux was good, I updated the PR |
Fix #1464